Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Updated copyClipboard glyph to be centered #5023

Merged
merged 6 commits into from
Aug 13, 2021

Conversation

elizabetdev
Copy link
Contributor

@elizabetdev elizabetdev commented Aug 12, 2021

Summary

Just noticed on #5018 that the copyClipboard icon was not centered. It was left-aligned so I fixed it to be centered.

Design

Screenshot 2021-08-12 at 16 01 08

Frame 1@2x

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5023/

@elizabetdev elizabetdev marked this pull request as ready for review August 12, 2021 16:43
@elizabetdev elizabetdev requested a review from cchaos August 12, 2021 16:51
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5023/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like that you centered the page portion instead of the whole icon 💯

In case you haven't yet, can you also be sure to update the Figma icon?

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5023/

@elizabetdev
Copy link
Contributor Author

Thanks @cchaos,

I also updated the Figma icon. 👍🏽

@elizabetdev elizabetdev merged commit fca531a into elastic:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants