[EuiFlyout] Fix usage of outsideClickCloses prop
#4986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 28, 2021 11:19
Which also fixes the signified default
|
Also, if anyone wants to push a change to this PR to fix the props table for EuiFlyout, please go ahead! Ref: #4980 |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4986/ |
thompsongl
approved these changes
Aug 10, 2021
|
Waiting for the current release to finish, then I'll update the CL again |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4986/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4986/ |
This was referenced Aug 12, 2021
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prop was originally introduced to help with flyouts that aren't showing an overlay mask (
ownFocus=true) to still allow any interaction on the page to close the flyout. The prop comment said it would also apply to the overlay mask, but it never did.I've changed the default to just be undefined instead of
falsesince it really all depends on theownFocusoption. And then set theonCloseevent on the overlay mask only ifoutsideClickCloses = false.You can test it on the temporary change to the
Without ownFocusexample where I kept theownFocus=truebut just setoutsideClickCloses=false.Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes