Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] Fix new threshold executor unit test #162299

Closed
maryam-saeidi opened this issue Jul 20, 2023 · 1 comment · Fixed by #167120
Closed

[AO] Fix new threshold executor unit test #162299

maryam-saeidi opened this issue Jul 20, 2023 · 1 comment · Fixed by #167120
Assignees
@maryam-saeidi
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" technical debt Improvement of the software architecture and operational architecture v8.10.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Jul 20, 2023 •
edited
Loading

📝 Summary

In the previous ticket (#155534), Chris fixed the unit test for the metric threshold rule executor, but since we already had a lot of changes in the new threshold rule, we couldn't unskip this test.

✅ Acceptance Criteria

  • Fix the unit test and remove the skip
@maryam-saeidi maryam-saeidi added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0 labels Jul 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi mentioned this issue Jul 20, 2023
Merged
@emma-raffenne emma-raffenne added this to the 8.10 milestone Aug 7, 2023
@emma-raffenne emma-raffenne removed this from the 8.10 milestone Aug 17, 2023
@emma-raffenne emma-raffenne added the technical debt Improvement of the software architecture and operational architecture label Sep 8, 2023
@maryam-saeidi maryam-saeidi self-assigned this Sep 22, 2023
@maryam-saeidi maryam-saeidi mentioned this issue Sep 25, 2023
Merged
maryam-saeidi added a commit that referenced this issue Sep 28, 2023
@maryam-saeidi
[AO] Unskip the custom threshold rule executor unit test (#167120)
6ab0c68 
Fixes #162299
Fixes #162540

## Summary

This PR unskips the custom threshold rule executor unit test and removes
the warning implementation from the BE.

## 🧪 How to test
- Create a custom threshold rule, it should work as before. (Warning
implementation logic was already removed from FE; this PR only removes
the BE implementation.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" technical debt Improvement of the software architecture and operational architecture v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AO] Unskip the custom threshold rule executor unit test maryam-saeidi/kibana
3 participants
@maryam-saeidi @elasticmachine @emma-raffenne