-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AO] Unskip the custom threshold rule executor unit test #167120
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
@@ -123,8 +133,7 @@ const setEvaluationResults = (response: Array<Record<string, Evaluation>>) => { | |||
jest.requireMock('./lib/evaluate_rule').evaluateRule.mockImplementation(() => response); | |||
}; | |||
|
|||
// FAILING: https://github.com/elastic/kibana/issues/155534 | |||
describe.skip('The metric threshold alert type', () => { | |||
describe('The metric threshold alert type', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but is it easy to to change threshold alert type
to threshold rule type
?
@maryam-saeidi Code review LGTM! I need to test it locally as well. What do |
I created a custom threshold rule and everything works as expected! |
@mgiota I mean, in the rule flyout (front-end), we already removed the warning threshold, so it is only possible to set the alert threshold. By back-end, I mean the rule execution logic in the server folder. |
Fixes #162299
Fixes #162540
Summary
This PR unskips the custom threshold rule executor unit test and removes the warning implementation from the BE.
🧪 How to test