Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] Remove warning implementation from BE for the new threshold rule #162540

Closed
maryam-saeidi opened this issue Jul 26, 2023 · 1 comment · Fixed by #167120
Closed

[AO] Remove warning implementation from BE for the new threshold rule #162540

maryam-saeidi opened this issue Jul 26, 2023 · 1 comment · Fixed by #167120
Assignees
@maryam-saeidi
Labels
Feature:Alerting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0

Comments

@maryam-saeidi
Copy link
Member

📝 Summary

In the previous ticket (#159496), we removed the warning threshold from the UI, but the BE code still has the logic of calculating it, for example, in this file. In this ticket, we want to clean up this logic from BE.

✅ Acceptance Criteria

  • Remove warning logic from BE
@maryam-saeidi maryam-saeidi added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0 labels Jul 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi self-assigned this Sep 25, 2023
@maryam-saeidi maryam-saeidi mentioned this issue Sep 25, 2023
Merged
maryam-saeidi added a commit that referenced this issue Sep 28, 2023
@maryam-saeidi
[AO] Unskip the custom threshold rule executor unit test (#167120)
6ab0c68 
Fixes #162299
Fixes #162540

## Summary

This PR unskips the custom threshold rule executor unit test and removes
the warning implementation from the BE.

## 🧪 How to test
- Create a custom threshold rule, it should work as before. (Warning
implementation logic was already removed from FE; this PR only removes
the BE implementation.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
Feature:Alerting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AO] Unskip the custom threshold rule executor unit test maryam-saeidi/kibana
3 participants
@maryam-saeidi @elasticmachine @emma-raffenne