Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/infra/server/lib/alerting/metric_threshold - The metric threshold alert type alerts with NO_DATA where one condtion is an aggregation and the other is a document count sends a No Data alert when configured to do so #155534

Closed
1 task done
kibanamachine opened this issue Apr 21, 2023 · 6 comments · Fixed by #162189
Closed
1 task done

Failing test: Jest Tests.x-pack/plugins/infra/server/lib/alerting/metric_threshold - The metric threshold alert type alerts with NO_DATA where one condtion is an aggregation and the other is a document count sends a No Data alert when configured to do so #155534

kibanamachine opened this issue Apr 21, 2023 · 6 comments · Fixed by #162189
Assignees
@simianhacker
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
Milestone
8.10

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 21, 2023 •
edited by emma-raffenne
Loading

A test failed on a tracked branch

TypeError: Cannot read properties of undefined (reading 'currentValue')
    at currentValue (/var/lib/buildkite-agent/builds/kb-n2-4-spot-25f1a2a1049841a3/elastic/kibana-on-merge/kibana/x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.ts:300:34)
    at Array.reduce (<anonymous>)
    at reduce (/var/lib/buildkite-agent/builds/kb-n2-4-spot-25f1a2a1049841a3/elastic/kibana-on-merge/kibana/x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.ts:299:47)
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-25f1a2a1049841a3/elastic/kibana-on-merge/kibana/x-pack/plugins/rule_registry/server/utils/create_lifecycle_rule_executor_mock.ts:38:5
    at Object.<anonymous> (/var/lib/buildkite-agent/builds/kb-n2-4-spot-25f1a2a1049841a3/elastic/kibana-on-merge/kibana/x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.test.ts:1400:7)

First failure: CI Build - main

Progress Tracking
Preview Give feedback
  1. [Alerts] Fixing skipped unit tests for metric threshold rule #162189
    Team: Actionable Observability - DEPRECATED backport:skip release_note:fix v8.10.0
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Apr 21, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 21, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz jbudz added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Apr 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 21, 2023
jbudz added a commit that referenced this issue Apr 21, 2023
@jbudz
skip flaky suite (#155534)
51d5387
@jbudz
Copy link
Member

jbudz commented Apr 21, 2023

Skipped

main: 51d5387

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@simianhacker simianhacker self-assigned this May 15, 2023
@simianhacker simianhacker mentioned this issue May 15, 2023
Closed
@maryam-saeidi maryam-saeidi added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Jul 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi removed the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Jul 7, 2023
@simianhacker simianhacker mentioned this issue Jul 18, 2023
Merged
simianhacker added a commit that referenced this issue Jul 19, 2023
@simianhacker
[Alerts] Fixing skipped unit tests for metric threshold rule (#162189)
8303ea9 
## Summary

This PR fixes #155534 by ensuring result for the group by is set before
adding it to the evaluation results. I also applied the fix to the new
Observability Threshold Rule since we are using it as a starting point
for the new combined rule.
@maryam-saeidi maryam-saeidi mentioned this issue Jul 20, 2023
Closed
ThomThomson pushed a commit to ThomThomson/kibana that referenced this issue Aug 1, 2023
@simianhacker
[Alerts] Fixing skipped unit tests for metric threshold rule (elastic…
7316344 
…#162189)

## Summary

This PR fixes elastic#155534 by ensuring result for the group by is set before
adding it to the evaluation results. I also applied the fix to the new
Observability Threshold Rule since we are using it as a starting point
for the new combined rule.
@emma-raffenne emma-raffenne added this to the 8.10 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simianhacker simianhacker

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
Projects
None yet
Milestone
8.10
6 participants
@simianhacker @jbudz @maryam-saeidi @elasticmachine @kibanamachine @emma-raffenne