[Alerts] Fixing skipped unit tests for metric threshold rule #162189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
release_note:fix
Team: Actionable Observability - DEPRECATED
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
maryam-saeidi
approved these changes
Jul 19, 2023
| @@ -1394,7 +1394,7 @@ describe.skip('The metric threshold alert type', () => { | |||
| await execute(true); | |||
| const recentAction = mostRecentAction(instanceID); | |||
| expect(recentAction.action).toEqual({ | |||
| alertDetailsUrl: 'http://localhost:5601/app/observability/alerts/mock-alert-uuid', | |||
| alertDetailsUrl: '', | |||
There was a problem hiding this comment.
Can we also remove the skip from this test? If not, I will create a separate ticket for it.
There was a problem hiding this comment.
Whoops... I missed that.
There was a problem hiding this comment.
That test needs a lot more work before we are ready to remove the skip statement. It's failing beyond just the single test this PR is fixing.
There was a problem hiding this comment.
I thought so, here is the ticket for it: #162299
…that's outside the scope of this PR
…xing-test-for-no-data
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…#162189) ## Summary This PR fixes elastic#155534 by ensuring result for the group by is set before adding it to the evaluation results. I also applied the fix to the new Observability Threshold Rule since we are using it as a starting point for the new combined rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #155534 by ensuring result for the group by is set before adding it to the evaluation results. I also applied the fix to the new Observability Threshold Rule since we are using it as a starting point for the new combined rule.