[RFC] match_only_text type migration - Stage 0
#1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
approved these changes
May 6, 2021
Co-authored-by: Adrien Grand <[email protected]>
djptek
reviewed
May 12, 2021
| * Span queries are unsupported. If a span query is run, then shards where the field is mapped as match_only_text will be returned as failed in the search response and their hits will be ignored. | ||
| * Phrase and intervals queries run slower. | ||
|
|
||
| Like `text`, `match_only_text` fields do not support aggregations. |
There was a problem hiding this comment.
There was a problem hiding this comment.
see related PR to Elasticsearch, I may cancel this review depending on the response from there also: elastic/elasticsearch#72985
There was a problem hiding this comment.
Great catch! I'll note this and include the change in the stage 1 PR for this RFC.
rylnd
added a commit
to rylnd/ecs
that referenced
this pull request
May 28, 2021
* master: Stage 2 changes for RFC 0018 - extending the `threat.*` field set (elastic#1438) Remove deprecated `host.user.*` fields (elastic#1439) Explicitly include user identifiers in `related.user` field description (elastic#1420) Set the merge date on RFC 0018 stage 2 (elastic#1429) [RFC] Extend Threat Fieldset - Stage 2 Proposal (elastic#1395) [Tooling] Add --exclude flag to Generator to support field removal testing (elastic#1411) Add `host.user.*` deprecation notice in field reuse description (elastic#1422) Stage 2 changes for RFC 0015 - `elf` header (elastic#1410) Stage 3 changes for RFC 0012 - `orchestrator` field set (elastic#1417) Support `match_only_text` in Go code generator (elastic#1418) Stage 3 Orchestrator RFC (elastic#1343) moving into folder (elastic#1416) removing use-cases (elastic#1405) removing --oss (elastic#1404) Set the merge date on RFC 0015 stage 2 (elastic#1409) Consolidate `Breaking changes` sections in `CHANGELOG.next` (elastic#1408) RFC-Stage-0: Proposal to add a "ticket" schema / field definition to ECS (elastic#1383) [RFC] `match_only_text` type migration - Stage 0 (elastic#1396) Client port is wrongly documented (elastic#1402) (elastic#1406)
ebadyano
added a commit
to ebadyano/rally-tracks
that referenced
this pull request
Jun 8, 2021
Relates to elastic#170 Relates to elastic/ecs#1396
ebadyano
added a commit
to elastic/rally-tracks
that referenced
this pull request
Jun 14, 2021
Relates to #170 Relates to elastic/ecs#1396
ebadyano
added a commit
to ebadyano/rally-tracks
that referenced
this pull request
Jun 15, 2021
Relates to elastic#170 Relates to elastic/ecs#1396
ebadyano
added a commit
to elastic/rally-tracks
that referenced
this pull request
Oct 13, 2021
Relates to #170 Relates to elastic/ecs#1396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stage 0 proposal for migrating
texttype fields, including themessagebase field, to use thematch_only_textdata type being introduced in Elasticsearch 7.14.Stage 0 (Strawperson) Criteria:
Preview of markdown proposal