Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client port is wrongly documented #1402

Merged
merged 1 commit into from
May 10, 2021
Merged

Client port is wrongly documented #1402

merged 1 commit into from
May 10, 2021

Conversation

srikwit
Copy link
Contributor

@srikwit srikwit commented May 10, 2021

The client port is wrongly documented as 64734 instead of 54162.

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
  • Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • Have you added an entry to the CHANGELOG.next.md?

@srikwit
Client port is wrongly documented
c623a77 
The client port is wrongly documented as 64734 instead of 54162.
@ebeahan ebeahan added the DOCS Any issue related to ECS documentation label May 10, 2021
@ebeahan
Copy link
Member

ebeahan commented May 10, 2021

@elasticmachine run elasticsearch-ci/docs

@ebeahan
Copy link
Member

ebeahan commented May 10, 2021

Thanks, @srikwit, and good catch! 👀

For some reason, the docs build check decided not to run, but I kicked it off manually.

ebeahan
ebeahan approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI came back ✅ and LGTM 👍

I'll handle merging and backporting. Thanks again!

@ebeahan ebeahan merged commit 13e71af into elastic:1.10 May 10, 2021
@ebeahan
Copy link
Member

ebeahan commented May 10, 2021

@srikwit didn't catch it until after the merge, but in the future, you can target all PRs against the master branch. From there we can backport any changes to the appropriate branches.

I'll handle getting this change applied to master and 1.x

ebeahan pushed a commit to ebeahan/ecs that referenced this pull request May 10, 2021
@srikwit @ebeahan
Client port is wrongly documented (elastic#1402)
2428595 
The client port is wrongly documented as 64734 instead of 54162.
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request May 10, 2021
@srikwit @ebeahan
Client port is wrongly documented (elastic#1402)
3e96124 
The client port is wrongly documented as 64734 instead of 54162.
This was referenced May 10, 2021
Merged
Merged
ebeahan added a commit that referenced this pull request May 10, 2021
@ebeahan @srikwit
Client port is wrongly documented (#1402) (#1407)
475bcb6 
The client port is wrongly documented as 64734 instead of 54162.

Co-authored-by: srikwit <[email protected]>
@srikwit
Copy link
Contributor Author

srikwit commented May 11, 2021

Thanks @ebeahan!

ebeahan added a commit that referenced this pull request May 11, 2021
@ebeahan @srikwit
Client port is wrongly documented (#1402) (#1406)
a7ce2d6 
The client port is wrongly documented as 64734 instead of 54162.

Co-authored-by: srikwit <[email protected]>
rylnd added a commit to rylnd/ecs that referenced this pull request May 28, 2021
@rylnd
Merge branch 'master' into threat-enrichment-stage-1
caa8983 
* master:
  Stage 2 changes for RFC 0018 - extending the `threat.*` field set (elastic#1438)
  Remove deprecated `host.user.*` fields (elastic#1439)
  Explicitly include user identifiers in `related.user` field description (elastic#1420)
  Set the merge date on RFC 0018 stage 2 (elastic#1429)
  [RFC] Extend Threat Fieldset - Stage 2 Proposal (elastic#1395)
  [Tooling] Add --exclude flag to Generator to support field removal testing (elastic#1411)
  Add `host.user.*` deprecation notice in field reuse description (elastic#1422)
  Stage 2 changes for RFC 0015 - `elf` header (elastic#1410)
  Stage 3 changes for RFC 0012 - `orchestrator` field set (elastic#1417)
  Support `match_only_text` in Go code generator (elastic#1418)
  Stage 3 Orchestrator RFC (elastic#1343)
  moving into folder (elastic#1416)
  removing use-cases (elastic#1405)
  removing --oss (elastic#1404)
  Set the merge date on RFC 0015 stage 2 (elastic#1409)
  Consolidate `Breaking changes` sections in `CHANGELOG.next` (elastic#1408)
  RFC-Stage-0: Proposal to add a "ticket" schema / field definition to ECS (elastic#1383)
  [RFC] `match_only_text` type migration - Stage 0 (elastic#1396)
  Client port is wrongly documented (elastic#1402) (elastic#1406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebeahan ebeahan ebeahan approved these changes

Assignees
No one assigned
Labels
1.x DOCS Any issue related to ECS documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srikwit @ebeahan @kgeller