Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support match_only_text in Go code generator #1418

Merged
merged 3 commits into from
May 17, 2021

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented May 14, 2021

Running make gocodegen (and in turn, make) will fail if a type isn't explicitly handled in scripts/cmd/gocodegen/gocodegen.go.

Adding support in the tooling for match_only_text as we look to introduce the type into ECS (RFC 0023).

@ebeahan ebeahan self-assigned this May 14, 2021
changed match_only-text to match_only_text in changelog
Copy link
Contributor

@djptek djptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I amended a typo in the CHANGELOG hope that's OK, LGTM

@ebeahan ebeahan merged commit 9b8c6f7 into elastic:master May 17, 2021
@ebeahan ebeahan deleted the feature/support-match_only_text-type branch May 17, 2021 18:54
ebeahan added a commit to ebeahan/ecs that referenced this pull request May 17, 2021
ebeahan added a commit that referenced this pull request May 17, 2021
rylnd added a commit to rylnd/ecs that referenced this pull request May 28, 2021
* master:
  Stage 2 changes for RFC 0018 - extending the `threat.*` field set (elastic#1438)
  Remove deprecated `host.user.*` fields (elastic#1439)
  Explicitly include user identifiers in `related.user` field description (elastic#1420)
  Set the merge date on RFC 0018 stage 2 (elastic#1429)
  [RFC] Extend Threat Fieldset - Stage 2 Proposal (elastic#1395)
  [Tooling] Add --exclude flag to Generator to support field removal testing (elastic#1411)
  Add `host.user.*` deprecation notice in field reuse description (elastic#1422)
  Stage 2 changes for RFC 0015 - `elf` header (elastic#1410)
  Stage 3 changes for RFC 0012 - `orchestrator` field set (elastic#1417)
  Support `match_only_text` in Go code generator (elastic#1418)
  Stage 3 Orchestrator RFC (elastic#1343)
  moving into folder (elastic#1416)
  removing use-cases (elastic#1405)
  removing --oss (elastic#1404)
  Set the merge date on RFC 0015 stage 2 (elastic#1409)
  Consolidate `Breaking changes` sections in `CHANGELOG.next` (elastic#1408)
  RFC-Stage-0: Proposal to add a "ticket" schema / field definition to ECS (elastic#1383)
  [RFC] `match_only_text` type migration - Stage 0 (elastic#1396)
  Client port is wrongly documented (elastic#1402) (elastic#1406)
@neu5ron
Copy link

neu5ron commented Sep 17, 2021

is match_only_text lowercase like text?

@kgeller
Copy link
Contributor

kgeller commented Sep 20, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants