Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly include user identifiers in related.user field description #1420

Merged

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented May 17, 2021

Capturing user identifiers in addition to user names in related.user can be useful, but the description for related.user implies the field is limited to only "user names".

Here's one instance where pivoting around the user's SID from one event helps track that SID back to a user name in another: #779 (comment)

Expanding the description for related.user also aligns with the description for related.hosts, specifying both "hostnames and other host identifiers".

Closes #1355

@ebeahan
Copy link
Member Author

ebeahan commented May 17, 2021

@elastic/security-external-integrations Any feedback for or against expanding related.user description to include user identifiers beyond user names?

Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the clarification

LGTM

@ebeahan ebeahan merged commit 3f9e513 into elastic:master May 26, 2021
@ebeahan ebeahan deleted the feature/improve-related-user-description branch May 26, 2021 19:03
ebeahan added a commit to ebeahan/ecs that referenced this pull request May 26, 2021
…on (elastic#1420)

* explicitly include user identifiers in description

* update artifacts

* changelog
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
rylnd added a commit to rylnd/ecs that referenced this pull request May 28, 2021
* master:
  Stage 2 changes for RFC 0018 - extending the `threat.*` field set (elastic#1438)
  Remove deprecated `host.user.*` fields (elastic#1439)
  Explicitly include user identifiers in `related.user` field description (elastic#1420)
  Set the merge date on RFC 0018 stage 2 (elastic#1429)
  [RFC] Extend Threat Fieldset - Stage 2 Proposal (elastic#1395)
  [Tooling] Add --exclude flag to Generator to support field removal testing (elastic#1411)
  Add `host.user.*` deprecation notice in field reuse description (elastic#1422)
  Stage 2 changes for RFC 0015 - `elf` header (elastic#1410)
  Stage 3 changes for RFC 0012 - `orchestrator` field set (elastic#1417)
  Support `match_only_text` in Go code generator (elastic#1418)
  Stage 3 Orchestrator RFC (elastic#1343)
  moving into folder (elastic#1416)
  removing use-cases (elastic#1405)
  removing --oss (elastic#1404)
  Set the merge date on RFC 0015 stage 2 (elastic#1409)
  Consolidate `Breaking changes` sections in `CHANGELOG.next` (elastic#1408)
  RFC-Stage-0: Proposal to add a "ticket" schema / field definition to ECS (elastic#1383)
  [RFC] `match_only_text` type migration - Stage 0 (elastic#1396)
  Client port is wrongly documented (elastic#1402) (elastic#1406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve related.user field description
2 participants