Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs amendment match-only-text has limited support for aggs #72985

Merged
merged 2 commits into from
May 12, 2021
Merged

docs amendment match-only-text has limited support for aggs #72985

merged 2 commits into from
May 12, 2021

Conversation

djptek
Copy link
Contributor

@djptek djptek commented May 12, 2021 •
edited by nik9000
Loading

Small correction to Docs for match_only_text states this field does not support aggs, however, you can still run an aggregations in some shape or form see this gist

If the intention is to reject aggs in the same way as sort e.g. by raising illegal_argument_exception then please reject this PR

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label May 12, 2021
@djptek djptek added the >docs General docs changes label May 12, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label May 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@djptek djptek added :Analytics/Aggregations Aggregations >new-field-mapper Added when a new field type / mapper is being introduced and removed >docs General docs changes Team:Docs Meta label for docs team labels May 12, 2021
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@djptek djptek mentioned this pull request May 12, 2021
Merged
2 tasks
@nik9000 nik9000 requested a review from jpountz May 12, 2021 14:28
@jpountz jpountz added :Search Foundations/Mapping Index mappings, including merging and defining field types >docs General docs changes and removed :Analytics/Aggregations Aggregations >new-field-mapper Added when a new field type / mapper is being introduced Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels May 12, 2021
@elasticmachine elasticmachine added Team:Search Meta label for search team Team:Docs Meta label for docs team labels May 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@jpountz jpountz merged commit dc43d05 into elastic:master May 12, 2021
@jpountz jpountz added >non-issue and removed >docs General docs changes labels May 12, 2021
@elasticmachine elasticmachine removed the Team:Docs Meta label for docs team label May 12, 2021
@jpountz
Copy link
Contributor

jpountz commented May 12, 2021

Labeling as non-issue since this field has not been released yet.

jpountz pushed a commit that referenced this pull request May 12, 2021
@djptek @jpountz
docs amendment match-only-text has limited support for aggs (#72985)
593945b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpountz jpountz jpountz approved these changes

Assignees
No one assigned
Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djptek @elasticmachine @jpountz @elasticsearchmachine