Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2597 remove proof #2774

Merged
merged 9 commits into from
Jan 2, 2024
Merged

2597 remove proof #2774

merged 9 commits into from
Jan 2, 2024

Conversation

dsawali
Copy link
Contributor

@dsawali dsawali commented Dec 20, 2023

closes #2597 #2648 #2647

  • removed originationProof and its references in Taquito and in tests
  • updated estimation values

Note that the failures in Oxfordnet tesnet integration tests are caused by the whitelist property addition in smart_rollup_originate. Ticket for reference: #2776

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

Copy link

github-actions bot commented Dec 20, 2023

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@dsawali dsawali changed the base branch from oxford2 to master December 20, 2023 20:23
@dsawali dsawali changed the base branch from master to oxford2 December 20, 2023 20:24
@dsawali dsawali marked this pull request as ready for review December 22, 2023 18:26
@dsawali dsawali requested a review from hui-an-yang December 22, 2023 20:06
Copy link
Collaborator

@hui-an-yang hui-an-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, looks like ticket#2647 #2648 can be closed by this pr too

@@ -29,7 +29,6 @@ await op.confirmation();
- `pvmKind` at this time the only PVM supported is `wasm_2_0_0`
- `kernel` is passed as a hexadecimal string examples can be found at [this tezos docs endpoint](https://tezos.gitlab.io/mumbai/smart_rollups.html?highlight=smart%20rollup%20originate#id1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link is 404 might want to update it to https://tezos.gitlab.io/active/smart_rollups.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this in this pr

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this too

@dsawali dsawali merged commit a39f699 into oxford2 Jan 2, 2024
3 of 7 checks passed
@dsawali dsawali deleted the 2597-remove-proof branch January 2, 2024 22:32
dsawali added a commit that referenced this pull request Jan 29, 2024
* 2762 oxford2 branch configuration (#2764)

* ci: initial configuration of oxford2 branch

re #2762

* docs: replaced mumbai ref with oxford2 of rpc_nodes and wallet_api on webstie

* docs: add oxfordnet to wallet_api in next version of website

* ci: update ci script origiante-known-contracts command

* remove tx rollups references in taquito (#2770)

* remove tx rollups references in taquito

* updated unit test

* removed remaining tx rollup references

* 2596 oxford2 update rpc types (#2772)

* feat: updated rpc endpoint changes for oxford2

re #2596

* fix: fix auto-merge mistake by removing tx ref

* test: fix integration test of pendingOperations

* test: removed unnecessory import

* refactor: imporved ux of rpc endpoint of blockOption version

* 2597 remove proof (#2774)

* removed references to originationProof

* trigger checks

* trigger checks

* test commit

* adjusted more tests

* removed remaining origination proof artifacts

* updated smart rollup docs

* adjusted estimates

* 2776 smart rollup origination with whitelist (#2781)

* removed references to originationProof

* trigger checks

* trigger checks

* test commit

* adjusted more tests

* removed remaining origination proof artifacts

* updated smart rollup docs

* adjusted estimates

* feat: supported smartRollupOriginate with new pvmKind and property whitelist in localForger

re #2776

* refactor: addressed comments of naming for clarity

* test: updated contract-estimation-tests-spec.ts assertions

---------

Co-authored-by: Davis Sawali <[email protected]>

* 2599 oxford2 supports attestation (#2775)

* feat: supports attesation along side endorsement

re #2599

* feat: the rest of files of supports attesation along side endorsement

* test: fix protocol logic in integration-tests/rpc-nodes.spec.ts

* test: addressed pr comments of naming

* test: updated contract-estimation-tests.spec.ts assertions

* 2653 oxford2 reintroduce timelock (#2780)

* test: added local-forging timelock test case with chest, chest_key and OPEN_CHEST

re #2653

* test: added integration test originating with chest&chest_key in storage (chest_key unfinished)

* test: updated chestKeyValue in integration-tests

re #2653

* test: removed unneeded comment

* test: address comment to reduce timeout risk

* Oxford2 cleanup (#2791)

* docs: updated to oxford references whereever fits

* feat: updated rpc types and doc changes

* ci: removed nairobi and replace mondaynet with weeklynet

* fix: replaced modanynet as weeklynet

* ci: comment out oxfordbox tests until oxford2 flextesa image releases

* docs: address typedoc comments

* removed newline

* chore(releng) bump version to 19.0.0-beta-RC.0

* chore: satisfy lerna

* chore(releng) bump version to 19.0.0

---------

Co-authored-by: Davis Sawali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update estimation assertion to be oxford Remove annotation on option and parameter
2 participants