2776 smart rollup origination with whitelist #2781

hui-an-yang · 2024-01-02T18:34:53Z

supporting whitelist property and new PVMkind riscv of smartRollupOrigination in localForging
closes #2776

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

Your code builds cleanly without any errors or warnings
You have run the linter against the changes
You have added unit tests (if relevant/appropriate)
You have added integration tests (if relevant/appropriate)
All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
You have added or updated corresponding documentation
If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

…itelist in localForger re #2776

github-actions · 2024-01-02T18:38:00Z

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

…76-smartRollupOrigination-with-whitelist

dsawali · 2024-01-02T23:27:45Z

packages/taquito-local-forging/src/decoder.ts

@@ -63,6 +64,7 @@ export const decoders: { [key: string]: Decoder } = {
  [CODEC.ZARITH]: zarithDecoder,
  [CODEC.PUBLIC_KEY]: publicKeyDecoder,
  [CODEC.PKH]: pkhDecoder,
+  [CODEC.PKH_ARR]: pkhsDecoder,


would you consider updating this to PKH_ARRAY or PKH_LIST instead for clarity?

At the time, trying to be consistent with existing PROPOSAL_ARR but I like your suggestions better

if the decoder going with pkhArrayDecoder will update this as PKH_ARRAY.

dsawali · 2024-01-02T23:28:31Z

packages/taquito-local-forging/src/codec.ts

@@ -57,6 +57,18 @@ export const pkhDecoder = (val: Uint8ArrayConsumer) => {
  }
 };

+export const pkhsDecoder = (val: Uint8ArrayConsumer) => {


what would the s be in this case in pkhs

same as the other comment inherit the naming consistency from proposalsDecoder, I think s means plural

I think for proposals it's because the operation itself is called Proposals instead of proposal.

I think we can remove the S in this case, but that's just personal preference.

there are proposalDecoder and proposalsDecoder. There is already pkhDecoder will we consider pkhArrayDecoder?

yeah let's do pkhArrayDecoder then, seems more informative than just using s.

dsawali

good work

* 2762 oxford2 branch configuration (#2764) * ci: initial configuration of oxford2 branch re #2762 * docs: replaced mumbai ref with oxford2 of rpc_nodes and wallet_api on webstie * docs: add oxfordnet to wallet_api in next version of website * ci: update ci script origiante-known-contracts command * remove tx rollups references in taquito (#2770) * remove tx rollups references in taquito * updated unit test * removed remaining tx rollup references * 2596 oxford2 update rpc types (#2772) * feat: updated rpc endpoint changes for oxford2 re #2596 * fix: fix auto-merge mistake by removing tx ref * test: fix integration test of pendingOperations * test: removed unnecessory import * refactor: imporved ux of rpc endpoint of blockOption version * 2597 remove proof (#2774) * removed references to originationProof * trigger checks * trigger checks * test commit * adjusted more tests * removed remaining origination proof artifacts * updated smart rollup docs * adjusted estimates * 2776 smart rollup origination with whitelist (#2781) * removed references to originationProof * trigger checks * trigger checks * test commit * adjusted more tests * removed remaining origination proof artifacts * updated smart rollup docs * adjusted estimates * feat: supported smartRollupOriginate with new pvmKind and property whitelist in localForger re #2776 * refactor: addressed comments of naming for clarity * test: updated contract-estimation-tests-spec.ts assertions --------- Co-authored-by: Davis Sawali <[email protected]> * 2599 oxford2 supports attestation (#2775) * feat: supports attesation along side endorsement re #2599 * feat: the rest of files of supports attesation along side endorsement * test: fix protocol logic in integration-tests/rpc-nodes.spec.ts * test: addressed pr comments of naming * test: updated contract-estimation-tests.spec.ts assertions * 2653 oxford2 reintroduce timelock (#2780) * test: added local-forging timelock test case with chest, chest_key and OPEN_CHEST re #2653 * test: added integration test originating with chest&chest_key in storage (chest_key unfinished) * test: updated chestKeyValue in integration-tests re #2653 * test: removed unneeded comment * test: address comment to reduce timeout risk * Oxford2 cleanup (#2791) * docs: updated to oxford references whereever fits * feat: updated rpc types and doc changes * ci: removed nairobi and replace mondaynet with weeklynet * fix: replaced modanynet as weeklynet * ci: comment out oxfordbox tests until oxford2 flextesa image releases * docs: address typedoc comments * removed newline * chore(releng) bump version to 19.0.0-beta-RC.0 * chore: satisfy lerna * chore(releng) bump version to 19.0.0 --------- Co-authored-by: Davis Sawali <[email protected]>

dsawali and others added 10 commits December 19, 2023 16:24

removed references to originationProof

ab211c0

trigger checks

2ebbb06

trigger checks

9132f7c

test commit

c511cba

adjusted more tests

65da505

removed remaining origination proof artifacts

fa171e1

updated smart rollup docs

d25afb8

resolved merge conflicts

9866c63

adjusted estimates

0766c54

feat: supported smartRollupOriginate with new pvmKind and property wh…

d8c1942

…itelist in localForger re #2776

hui-an-yang changed the base branch from oxford2 to 2597-remove-proof January 2, 2024 18:37

hui-an-yang linked an issue Jan 2, 2024 that may be closed by this pull request

[Oxford2] Update local forger to include 'whitelist' property for smart rollup originate #2776

Closed

hui-an-yang requested a review from dsawali January 2, 2024 20:25

hui-an-yang marked this pull request as ready for review January 2, 2024 20:25

Base automatically changed from 2597-remove-proof to oxford2 January 2, 2024 22:32

Merge branch 'oxford2' of https://github.com/ecadlabs/taquito into 27…

da9b6eb

…76-smartRollupOrigination-with-whitelist

dsawali reviewed Jan 2, 2024

View reviewed changes

refactor: addressed comments of naming for clarity

40b1ec7

hui-an-yang requested a review from dsawali January 4, 2024 19:21

test: updated contract-estimation-tests-spec.ts assertions

fc646c5

dsawali approved these changes Jan 5, 2024

View reviewed changes

hui-an-yang merged commit cd1f805 into oxford2 Jan 5, 2024
4 of 7 checks passed

hui-an-yang deleted the 2776-smartRollupOrigination-with-whitelist branch January 5, 2024 21:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2776 smart rollup origination with whitelist #2781

2776 smart rollup origination with whitelist #2781

hui-an-yang commented Jan 2, 2024 •

edited

Loading

github-actions bot commented Jan 2, 2024 •

edited

Loading

dsawali Jan 2, 2024

hui-an-yang Jan 3, 2024

hui-an-yang Jan 3, 2024

dsawali Jan 2, 2024

hui-an-yang Jan 3, 2024

dsawali Jan 3, 2024

hui-an-yang Jan 3, 2024

dsawali Jan 3, 2024

dsawali left a comment

2776 smart rollup origination with whitelist #2781

2776 smart rollup origination with whitelist #2781

Conversation

hui-an-yang commented Jan 2, 2024 • edited Loading

Release Note Draft Snippet

github-actions bot commented Jan 2, 2024 • edited Loading

Published packages:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsawali left a comment

Choose a reason for hiding this comment

hui-an-yang commented Jan 2, 2024 •

edited

Loading

github-actions bot commented Jan 2, 2024 •

edited

Loading