Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change endorsement into attestation #2599

Closed
dsawali opened this issue Aug 9, 2023 · 1 comment · Fixed by #2666 or #2775
Closed

Change endorsement into attestation #2599

dsawali opened this issue Aug 9, 2023 · 1 comment · Fixed by #2666 or #2775
Assignees
@hui-an-yang
Labels
2 breaking change A change that will break API or smart contract interactions oxford oxford2
Milestone
v19

Comments

@dsawali
Copy link
Contributor

dsawali commented Aug 9, 2023

Protocol Oxford introduces a renaming of all things related to endorsement or endorsing into attestation or attesting.

Do a run through of Taquito and update the names accordingly in:

  • the codebase (types, rpc responses, constants, etc)
  • the documentation (website, docs)
  • the Taquito test dapp (if any)
@dsawali dsawali added breaking change A change that will break API or smart contract interactions oxford labels Aug 9, 2023
@Innkst Innkst added this to the v18 milestone Aug 16, 2023
@dsawali dsawali added the 2 label Aug 24, 2023
@hui-an-yang
Copy link
Collaborator

hui-an-yang commented Aug 31, 2023 •
edited
Loading

created a of attestation test case in integration-tests/data/allTestsCases.ts to be tested in local-forging.spec.ts

@hui-an-yang hui-an-yang self-assigned this Sep 13, 2023
@hui-an-yang hui-an-yang linked a pull request Sep 23, 2023 that will close this issue
2599 oxford supports attestation #2666
Merged
9 tasks
@dsawali dsawali modified the milestones: v18, v19 Dec 12, 2023
@dsawali dsawali reopened this Dec 12, 2023
hui-an-yang added a commit that referenced this issue Dec 21, 2023
@hui-an-yang
feat: supports attesation along side endorsement
77b6025 
re #2599
@hui-an-yang hui-an-yang mentioned this issue Dec 22, 2023
Merged
9 tasks
@hui-an-yang hui-an-yang linked a pull request Jan 5, 2024 that will close this issue
2599 oxford2 supports attestation #2775
Merged
9 tasks
hui-an-yang added a commit that referenced this issue Jan 5, 2024
@hui-an-yang
2599 oxford2 supports attestation (#2775)
4a0a6e8 
* feat: supports attesation along side endorsement

re #2599

* feat: the rest of files of supports attesation along side endorsement

* test: fix protocol logic in integration-tests/rpc-nodes.spec.ts

* test: addressed pr comments of naming

* test: updated contract-estimation-tests.spec.ts assertions
dsawali added a commit that referenced this issue Jan 29, 2024
@hui-an-yang @dsawali
Oxford2 (#2771)
0470023 
* 2762 oxford2 branch configuration (#2764)

* ci: initial configuration of oxford2 branch

re #2762

* docs: replaced mumbai ref with oxford2 of rpc_nodes and wallet_api on webstie

* docs: add oxfordnet to wallet_api in next version of website

* ci: update ci script origiante-known-contracts command

* remove tx rollups references in taquito (#2770)

* remove tx rollups references in taquito

* updated unit test

* removed remaining tx rollup references

* 2596 oxford2 update rpc types (#2772)

* feat: updated rpc endpoint changes for oxford2

re #2596

* fix: fix auto-merge mistake by removing tx ref

* test: fix integration test of pendingOperations

* test: removed unnecessory import

* refactor: imporved ux of rpc endpoint of blockOption version

* 2597 remove proof (#2774)

* removed references to originationProof

* trigger checks

* trigger checks

* test commit

* adjusted more tests

* removed remaining origination proof artifacts

* updated smart rollup docs

* adjusted estimates

* 2776 smart rollup origination with whitelist (#2781)

* removed references to originationProof

* trigger checks

* trigger checks

* test commit

* adjusted more tests

* removed remaining origination proof artifacts

* updated smart rollup docs

* adjusted estimates

* feat: supported smartRollupOriginate with new pvmKind and property whitelist in localForger

re #2776

* refactor: addressed comments of naming for clarity

* test: updated contract-estimation-tests-spec.ts assertions

---------

Co-authored-by: Davis Sawali <[email protected]>

* 2599 oxford2 supports attestation (#2775)

* feat: supports attesation along side endorsement

re #2599

* feat: the rest of files of supports attesation along side endorsement

* test: fix protocol logic in integration-tests/rpc-nodes.spec.ts

* test: addressed pr comments of naming

* test: updated contract-estimation-tests.spec.ts assertions

* 2653 oxford2 reintroduce timelock (#2780)

* test: added local-forging timelock test case with chest, chest_key and OPEN_CHEST

re #2653

* test: added integration test originating with chest&chest_key in storage (chest_key unfinished)

* test: updated chestKeyValue in integration-tests

re #2653

* test: removed unneeded comment

* test: address comment to reduce timeout risk

* Oxford2 cleanup (#2791)

* docs: updated to oxford references whereever fits

* feat: updated rpc types and doc changes

* ci: removed nairobi and replace mondaynet with weeklynet

* fix: replaced modanynet as weeklynet

* ci: comment out oxfordbox tests until oxford2 flextesa image releases

* docs: address typedoc comments

* removed newline

* chore(releng) bump version to 19.0.0-beta-RC.0

* chore: satisfy lerna

* chore(releng) bump version to 19.0.0

---------

Co-authored-by: Davis Sawali <[email protected]>
@ac10n ac10n moved this to Done in Taquito Dev Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hui-an-yang hui-an-yang

Labels
2 breaking change A change that will break API or smart contract interactions oxford oxford2
Projects
Taquito Dev
Status: Done
Milestone
v19
3 participants
@dsawali @Innkst @hui-an-yang