2599 oxford supports attestation #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-supports-attestation
…-supports-attestation
… with only attesation BREAKING CHANGE: localforger only forge and parse atteation now
✅ Deploy Preview for taquito-test-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages: |
|
A new deploy preview is available on Netlify at https://b1bcc1d--tezostaquito.netlify.app |
ac10n
reviewed
Sep 25, 2023
| @@ -29,7 +33,7 @@ async function example() { | |||
| } | |||
|
|
|||
| tezos.stream.subscribeOperation({ | |||
| or: [bakerEndorsementFilter, bakerDelegation] | |||
| or: [bakeAttestationFilter, bakerEndorsementFilter, bakerDelegation] | |||
There was a problem hiding this comment.
Is including both endorsement and attestation something temporary? From my understanding, after the transition is complete, we need both for historical data, but only attestation for new blocks?
There was a problem hiding this comment.
Can be either, this is an example code shows how to use streamProvider. It's focussing on poling the newest block on chain. Protocol oxford might still be endorsement and for protocol P will change to attestation. For user to foresee this change doesn't hurt to have both to make sure their transition is seamless.
ac10n
reviewed
Sep 25, 2023
| @@ -191,6 +221,14 @@ export interface InlinedPreEndorsement { | |||
|
|
|||
| export type BallotVote = 'nay' | 'yay' | 'pass'; | |||
|
|
|||
| export interface OperationContentsAttestation { | |||
| kind: OpKind.ATTESTATION; | |||
| slot: number; | |||
There was a problem hiding this comment.
Should slot and round be required or optional?
There was a problem hiding this comment.
both required, here the openAPI reference
"018-Proxford.operation.alpha.operation_contents_and_result": {
"oneOf": [
{
"title": "Attestation",
"type": "object",
"properties": {
"kind": {
"type": "string",
"enum": [
"attestation"
]
},
"slot": {
"type": "integer",
"minimum": 0,
"maximum": 65535
},
"level": {
"type": "integer",
"minimum": -2147483648,
"maximum": 2147483647
},
"round": {
"type": "integer",
"minimum": -2147483648,
"maximum": 2147483647
},
"block_payload_hash": {
"$ref": "#/components/schemas/value_hash"
},
"metadata": {
"type": "object",
"properties": {
"balance_updates": {
"$ref": "#/components/schemas/018-Proxford.operation_metadata_with_legacy_attestation_name.alpha.balance_updates"
},
"delegate": {
"$ref": "#/components/schemas/Signature.Public_key_hash"
},
"consensus_power": {
"type": "integer",
"minimum": -1073741824,
"maximum": 1073741823
},
"consensus_key": {
"$ref": "#/components/schemas/Signature.Public_key_hash"
}
},
"required": [
"delegate",
"consensus_power",
"consensus_key"
]
}
},
"required": [
"kind",
"slot",
"level",
"round",
"block_payload_hash",
"metadata"
]
},
ac10n
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBERin the description box (when applicable)Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.