Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove annotation on option and parameter #2647

Closed
hui-an-yang opened this issue Sep 11, 2023 · 1 comment · Fixed by #2774
Closed

Remove annotation on option and parameter #2647

hui-an-yang opened this issue Sep 11, 2023 · 1 comment · Fixed by #2774
Assignees
@dsawali
Labels
oxford
Milestone
v19

Comments

@hui-an-yang
Copy link
Collaborator

Michelson: cleanup legacy annotation management. (MR !8208)

Currently Oxfordnet integeration test ./tzip16-metadata-view.spec.ts is failing due to annotation on option and parameter.
Will need to update the contract to remove annotation on option and parameter
@Innkst Innkst added this to the v18 milestone Sep 11, 2023
@hui-an-yang hui-an-yang self-assigned this Sep 14, 2023
@hui-an-yang
Copy link
Collaborator Author

hui-an-yang commented Sep 20, 2023 •
edited
Loading

Hello @e-asphyx

When you have time we will appreciate if you can help us to have a look of tezos MR !8208, if there's any change needed in @taquito/michel-codec?
In short, my understanding is that they removed annotation on option and parameter
Thank you so much!

@hui-an-yang hui-an-yang linked a pull request Sep 20, 2023 that will close this issue
2647 oxford remove annot on option parameter #2662
Closed
9 tasks
@hui-an-yang hui-an-yang mentioned this issue Sep 20, 2023
Closed
9 tasks
@Innkst Innkst modified the milestones: v18, v19 Dec 13, 2023
@hui-an-yang hui-an-yang assigned dsawali and unassigned hui-an-yang Dec 22, 2023
@hui-an-yang hui-an-yang linked a pull request Dec 22, 2023 that will close this issue
2597 remove proof #2774
Merged
9 tasks
@dsawali dsawali mentioned this issue Dec 23, 2023
Merged
9 tasks
@ac10n ac10n moved this to Done in Taquito Dev Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsawali dsawali

Labels
oxford
Projects
Taquito Dev
Status: Done
Milestone
v19
3 participants
@dsawali @Innkst @hui-an-yang