Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getOriginationProof RPC method in Taquito #2597

Closed
dsawali opened this issue Aug 9, 2023 · 1 comment · Fixed by #2664
Closed

Remove getOriginationProof RPC method in Taquito #2597

dsawali opened this issue Aug 9, 2023 · 1 comment · Fixed by #2664
Assignees
@dsawali
Labels
2 oxford oxford2 rpc
Milestone
v19

Comments

@dsawali
Copy link
Contributor

dsawali commented Aug 9, 2023 •
edited
Loading

Protocol Oxford removes the RPC for computing smart rollups' origination proof.

  • Remove the RPC method in @taquito/rpc, including rpc-cache, interface, etc
  • Remove tests related to the origination proof RPC endpoint
  • Remove it from smart rollup origination parameters in the Contract API, PrepareProvider, etc

relevant documents:
@Innkst Innkst added this to the v18 milestone Aug 16, 2023
@dsawali dsawali added 1 2 and removed 1 labels Aug 24, 2023
@hui-an-yang hui-an-yang self-assigned this Sep 14, 2023
@hui-an-yang
Copy link
Collaborator

hui-an-yang commented Sep 18, 2023 •
edited
Loading

The field commitment in the operation Sc_rollup_cement is now removed. It was no longer used and was deprecated in Nairobi. This also mean that the commitment does not need to be provided in the client command. (MR !8850)
Before::
./octez-client cement commitment from for smart rollup
Now::
./octez-client cement commitment from for smart rollup

removed property commitment in SmartRollupCement @taquito/rpc

hui-an-yang added a commit that referenced this issue Sep 20, 2023
@hui-an-yang
fix: removed commitment property in SmartRollupCement for oxford
24323a2 
re #2597
@hui-an-yang hui-an-yang linked a pull request Sep 21, 2023 that will close this issue
2597 oxford remove get origination proof #2664
Merged
9 tasks
@hui-an-yang hui-an-yang mentioned this issue Sep 22, 2023
Merged
9 tasks
hui-an-yang added a commit that referenced this issue Sep 22, 2023
@hui-an-yang
2597 oxford remove get origination proof (#2664)
d631b4e 
* refactor: updated rpc types to accomdate both attestation and endorement

* fix: fixed annots on option test fail

* revert: unintional attestation file change

* revert: unintional cspell.json changes

* fix: remove getOriginationProof RPC endpoint and ref in smartRollupOriginate op

BREAKING CHANGE: 1. rpc endpoint getOriginationProof removal 2.

* fix: removed commitment property in SmartRollupCement for oxford

re #2597

* test: updated consumedMilligas assertion in contract-estimation-tests.spec.ts
@hui-an-yang hui-an-yang mentioned this issue Sep 22, 2023
Closed
9 tasks
@dsawali dsawali reopened this Dec 12, 2023
@dsawali dsawali modified the milestones: v18, v19 Dec 12, 2023
@dsawali dsawali assigned dsawali and unassigned hui-an-yang Dec 19, 2023
@dsawali dsawali mentioned this issue Dec 20, 2023
Closed
9 tasks
@dsawali dsawali mentioned this issue Dec 20, 2023
Merged
9 tasks
@ac10n ac10n moved this to Done in Taquito Dev Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsawali dsawali

Labels
2 oxford oxford2 rpc
Projects
Taquito Dev
Status: Done
Milestone
v19
Development

Successfully merging a pull request may close this issue.

2597 oxford remove get origination proof ecadlabs/taquito
2597 remove proof ecadlabs/taquito
3 participants
@dsawali @Innkst @hui-an-yang