QST #715

devinrsmith · 2021-06-04T21:22:45Z

No description provided.

devinrsmith · 2021-06-14T15:27:56Z

Documentation requirements:

Minimally, javadoc.
Maximally, some low-level developer focused documentation on creating.

chipkent · 2021-06-22T19:29:25Z

qst/build.gradle

@@ -0,0 +1,12 @@
+dependencies {


General note: Before merging this stuff, it needs comprehensive, high-quality javadoc, since it is very user-facing.

qst/src/main/java/io/deephaven/qst/table/column/type/ColumnType.java

qst/src/main/java/io/deephaven/qst/table/column/type/ColumnTypeMappings.java

qst/src/main/java/io/deephaven/qst/table/column/type/ColumnType.java

qst/src/main/java/io/deephaven/qst/table/column/type/ColumnTypeBase.java

qst/src/test/java/io/deephaven/qst/ColumnHeaderTest.java

qst/src/test/java/io/deephaven/qst/ColumnTest.java

qst/src/main/java/io/deephaven/qst/table/column/Column.java

chipkent · 2021-06-22T21:10:11Z

qst/build.gradle

@@ -0,0 +1,12 @@
+dependencies {
+    annotationProcessor 'org.immutables:value:2.8.1'


General note: This is a user-facing API. It needs to do extensive null checking to save users debugging effort and to save us support effort. Clearly not a worry for the prototype, but it is a concern for production.

qst/src/main/java/io/deephaven/qst/AllowNulls.java

qst/src/main/java/io/deephaven/qst/table/Table.java

qst/src/main/java/io/deephaven/qst/table/column/header/ColumnHeader.java

qst/src/main/java/io/deephaven/qst/table/NewTable.java

qst/src/main/java/io/deephaven/qst/table/column/type/ColumnTypeBase.java

…rmats

table-api/src/main/java/io/deephaven/api/filter/Filter.java

qst/src/main/java/io/deephaven/qst/type/Type.java

qst/src/main/java/io/deephaven/qst/type/KnownColumnTypes.java

qst/src/main/java/io/deephaven/qst/column/header/ColumnHeader.java

qst/src/main/java/io/deephaven/qst/column/header/ColumnHeaders6.java

qst/src/main/java/io/deephaven/qst/table/NewTable.java

DB/src/main/java/io/deephaven/db/tables/ColumnDefinition.java

DB/src/main/java/io/deephaven/db/tables/Table.java

rcaudy · 2021-07-23T14:53:59Z

graphviz/build.gradle

@@ -0,0 +1,36 @@
+plugins {


I'm not going to review the graphviz stuff. Maybe @niloc132 is a good reviewer for that, or maybe we should make a separate PR for it.

I'll remove the graphviz from this PR.

Don't forget to create your new PR.

qst/src/main/java/io/deephaven/qst/Examples4.java

qst/src/main/java/io/deephaven/qst/DefaultStyle.java

qst/src/main/java/io/deephaven/qst/table/JoinBase.java

qst/src/main/java/io/deephaven/qst/table/HeadTable.java

qst/src/main/java/io/deephaven/qst/table/HeaderVisitor.java

qst/src/main/java/io/deephaven/qst/table/MergeTable.java

qst/src/main/java/io/deephaven/qst/table/ParentsVisitor.java

rcaudy

These comments cover all of the commits since my last review.

qst/src/main/java/io/deephaven/qst/column/header/ColumnHeadersN.java

qst/src/main/java/io/deephaven/qst/column/header/ColumnHeader.java

qst/src/main/java/io/deephaven/qst/array/Array.java

qst/src/main/java/io/deephaven/qst/array/DoubleArray.java

qst/src/main/java/io/deephaven/qst/array/PrimitiveArrayHelper.java

DB/src/main/java/io/deephaven/db/v2/sources/DateTimeArraySource.java

…umption.

This reverts commit 1d1b470

rcaudy

I think this is in a pretty good state. I'm overall still worried about JavaDoc, but my other concerns all have follow-on tickets at this time. At the least the vector type ticket needs to come in with this before MVP, I think.

DB/src/main/java/io/deephaven/db/v2/sources/ArrayBackedColumnSource.java

qst/src/main/java/io/deephaven/qst/table/HeadTable.java

DB/src/main/java/io/deephaven/db/tables/ColumnDefinition.java

Unavailable to review, and this is ready to merge. Any requests for additional work can be done in subsequent PRs.

devinrsmith added the java-api-basic label Jun 4, 2021

devinrsmith added this to the June 2021 milestone Jun 4, 2021

devinrsmith requested review from nbauernfeind and JamesXNelson June 4, 2021 21:22

devinrsmith self-assigned this Jun 4, 2021

devinrsmith added the DocumentationNeeded label Jun 14, 2021

devinrsmith requested a review from chipkent June 15, 2021 15:07

chipkent previously requested changes Jun 22, 2021

View reviewed changes

devinrsmith requested a review from rcaudy June 25, 2021 19:53

rcaudy reviewed Jun 25, 2021

View reviewed changes

devinrsmith force-pushed the qst branch from be92326 to ff283ef Compare July 20, 2021 22:17

Added qst

dc0b016

devinrsmith force-pushed the qst branch from ff283ef to dc0b016 Compare July 20, 2021 22:41

devinrsmith marked this pull request as ready for review July 20, 2021 22:42

devinrsmith requested a review from rcaudy July 20, 2021 22:42

devinrsmith changed the title ~~Initial QST prototype~~ QST Jul 21, 2021

devinrsmith added 4 commits July 21, 2021 07:56

Make qst array serializable

6e3444d

Hack around deephaven#875

1d9930e

Updated graphviz with better library that can output to a bunch of fo…

c591b34

…rmats

fix formatting

722d5bb

rcaudy reviewed Jul 22, 2021

View reviewed changes

devinrsmith added 3 commits July 22, 2021 15:40

KnownColumnTypes visitor isn't expecting custom

ea002a6

move known types to KnownColumnTypes

1e32fae

remove ColumnHeaderX static builders

d71b669

rcaudy reviewed Jul 23, 2021

View reviewed changes

devinrsmith added 4 commits July 23, 2021 10:59

NewTable / ColumnHeader review updates

fe5b5f3

Default builder capacity

62bec7a

Table.of return type

77d5b98

Create io.deephaven.annotations

336d6f6

devinrsmith added 7 commits July 23, 2021 14:50

TypeHelper

7bfe725

move qst array constants into Util

947c46b

make Ryan feel good

191f0d0

Add primitive helpers to Column

2b9ce00

null long

5d1e488

move adapts to Util

9fa65a6

remove graphviz from PR

3629369

devinrsmith requested a review from rcaudy July 23, 2021 22:25

rcaudy reviewed Jul 26, 2021

View reviewed changes

devinrsmith added 8 commits July 26, 2021 06:50

row N varargs check

5a45d03

ColumnHeader param name

1c0a360

non-reflective primitive array builders

0595683

fix unit test, create getMemoryColumnSourceForBoolean

6344469

TableCreation javadoc

2a129d2

Fixup BooleanArray. Add addImpl for more efficient boxed varargs cons…

0f70db6

…umption.

Revert "remove iterable->collection methods"

f2e5382

This reverts commit 1d1b470

remove unused method

7dd0c2b

devinrsmith requested a review from rcaudy July 26, 2021 14:53

rcaudy reviewed Jul 26, 2021

View reviewed changes

DB/src/main/java/io/deephaven/db/v2/sources/ArrayBackedColumnSource.java Outdated Show resolved Hide resolved

qst/src/main/java/io/deephaven/qst/table/HeadTable.java Outdated Show resolved Hide resolved

DB/src/main/java/io/deephaven/db/tables/ColumnDefinition.java Show resolved Hide resolved

devinrsmith added 6 commits July 29, 2021 09:47

Merge remote-tracking branch 'upstream/main' into tmp

8253f12

SnapshotTable does initial snapshot by default

0d8bee7

getBooleanMemoryColumnSource

64e5260

allow Head/TailTable w/ zero size

062bafe

rename qst Table -> TableSpec

99613c4

Javadocs

597328d

rcaudy approved these changes Jul 29, 2021

View reviewed changes

devinrsmith merged commit 4e6c325 into deephaven:main Jul 29, 2021

devinrsmith deleted the qst branch July 29, 2021 22:08

jmao-denver pushed a commit to jmao-denver/deephaven-core that referenced this pull request Apr 11, 2022

QST (deephaven#715)

2cdbc58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

QST #715

QST #715

devinrsmith commented Jun 4, 2021

devinrsmith commented Jun 14, 2021

chipkent Jun 22, 2021

chipkent Jun 22, 2021

rcaudy Jul 23, 2021

devinrsmith Jul 23, 2021

rcaudy Jul 26, 2021

rcaudy left a comment

rcaudy left a comment

		@@ -0,0 +1,12 @@
		dependencies {
		annotationProcessor 'org.immutables:value:2.8.1'

QST #715

QST #715

Conversation

devinrsmith commented Jun 4, 2021

devinrsmith commented Jun 14, 2021

chipkent Jun 22, 2021

Choose a reason for hiding this comment

chipkent Jun 22, 2021

Choose a reason for hiding this comment

rcaudy Jul 23, 2021

Choose a reason for hiding this comment

devinrsmith Jul 23, 2021

Choose a reason for hiding this comment

rcaudy Jul 26, 2021

Choose a reason for hiding this comment

rcaudy left a comment

Choose a reason for hiding this comment

rcaudy left a comment

Choose a reason for hiding this comment