Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-complete on instance should not suggest static methods #875

Open
devinrsmith opened this issue Jul 21, 2021 · 1 comment
Open

Auto-complete on instance should not suggest static methods #875

devinrsmith opened this issue Jul 21, 2021 · 1 comment
Assignees
Labels
autocomplete bug Something isn't working
Milestone

Comments

@devinrsmith
Copy link
Member

I added a new static method on io.deephaven.db.tables.Table. This is causing the following test to fail:

Condition not satisfied:

results.size() == 0
|       |      |
|       1      false
[
t = emptyTable(10)
u = t.of(]

	at io.deephaven.lang.completion.ChunkerCompletionHandlerTest.Methods on binding variables that were assigned a value from an emptyTable method returning Table will know it is a table(ChunkerCompletionHandlerTest.groovy:118)

From James: "there never used to be static methods on table, so I think it simply was not exercised properly"

           if (Modifier.isPublic(method.getModifiers())) {
                // TODO we'll likely want to pick between static or instance methods, based on calling scope.
                //   IDS-1517-19
                if (camelMatch(method.getName(), methodPrefix)) {
                    sorter.add(method.getName(), method);
                }
            }

Note: the property ChunkerCompleter.PROP_SUGGEST_STATIC_METHODS is only for statically imported static methods, and not relevant to this issue at hand on an instance.

@devinrsmith devinrsmith added bug Something isn't working autocomplete labels Jul 21, 2021
@devinrsmith devinrsmith added this to the Backlog milestone Jul 21, 2021
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Jul 21, 2021
@JamesXNelson
Copy link
Member

Cool. @devinrsmith if it's too much trouble to mod the test, feel free to @Ignore("#875") the test so I can reenable it when I get to this one.

devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocomplete bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants