Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java API] Explore QST Impl #710

Closed
nbauernfeind opened this issue Jun 4, 2021 · 0 comments · Fixed by #715
Closed

[Java API] Explore QST Impl #710

nbauernfeind opened this issue Jun 4, 2021 · 0 comments · Fixed by #715

Comments

@nbauernfeind
Copy link
Member

nbauernfeind commented Jun 4, 2021

Devin demo'd the power and allure of https://immutables.github.io/. It looks pretty promising. Visitor pattern from Immutable QST to the BatchTable protobuf request should be straight forward.

The approach is not extensible for custom operations; but neither is batch -- one would need to plumb the custom operation through batch to be able to add the custom operation to the QST. The integration with batch is sufficient effort that the additional overhead to add it to the QST (if he/she cares) is a reasonably small amount of additional effort.

The goal here is to demo some form of a QST being constructed before the worker connection, connect to worker, instantiate QST, finally demo access to result table in QST. We need buy in from the larger group on the approach, before flushing out all operations.

Follow Up Task: #711
Epic: Java API #257

@nbauernfeind nbauernfeind added this to the June 2021 milestone Jun 4, 2021
@nbauernfeind nbauernfeind self-assigned this Jun 4, 2021
@nbauernfeind nbauernfeind changed the title Java API Explore QST Impl [Java API] Explore QST Impl Jun 4, 2021
@nbauernfeind nbauernfeind linked a pull request Jul 23, 2021 that will close this issue
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants