QST

qst/src/main/java/io/deephaven/qst/array/Array.java

@@ -4,7 +4,6 @@
 
 import java.io.Serializable;
 import java.util.Collection;
-import java.util.stream.Stream;
 
 /**
  * Provides strong typing around an array-like object.
@@ -13,7 +12,7 @@
  * @see PrimitiveArray
  * @see GenericArray
  */
-public interface Array<T> extends Iterable<T>, Serializable {
+public interface Array<T> extends Serializable {
 
     static <T> ArrayBuilder<T, ?, ?> builder(Type<T> type) {
         return TypeToArrayBuilder.of(type, Util.DEFAULT_BUILDER_INITIAL_CAPACITY);
@@ -39,10 +38,6 @@ static <T> Array<T> of(Type<T> type, Collection<T> data) {
 
     int size();
 
-    T get(int index);
-
-    Stream<T> stream();
-
     <V extends Visitor> V walk(V visitor);
 
     interface Visitor {

qst/src/main/java/io/deephaven/qst/array/BooleanArray.java

@@ -64,11 +64,6 @@ public final byte[] values() {
         return values;
     }
 
-    @Override
-    public final Boolean get(int index) {
-        return adapt(values[index]);
-    }
-
     @Override
     public final int size() {
         return values().length;
@@ -110,44 +105,44 @@ private Builder(int initialCapacity) {
             this.size = 0;
         }
 
-        public synchronized final Builder add(boolean item) {
+        public final Builder add(boolean item) {
             ensureCapacity();
             array[size++] = adapt(item);
             return this;
         }
 
-        public synchronized final Builder add(boolean... items) {
+        public final Builder add(boolean... items) {
             for (boolean item : items) {
                 add(item);
             }
             return this;
         }
 
         @Override
-        public synchronized final Builder add(Boolean item) {
+        public final Builder add(Boolean item) {
             ensureCapacity();
             array[size++] = adapt(item);
             return this;
         }
 
         @Override
-        public synchronized final Builder add(Boolean... items) {
+        public final Builder add(Boolean... items) {
             for (Boolean item : items) {
                 add(item);
             }
             return this;
         }
 
         @Override
-        public synchronized final Builder add(Iterable<Boolean> items) {
+        public final Builder add(Iterable<Boolean> items) {
             for (Boolean item : items) {
                 add(item);
             }
             return this;
         }
 
         @Override
-        public synchronized final BooleanArray build() {
+        public final BooleanArray build() {
             return new BooleanArray(takeAtSize());
         }
 

qst/src/main/java/io/deephaven/qst/array/ByteArray.java

@@ -56,11 +56,6 @@ public final byte[] values() {
         return values;
     }
 
-    @Override
-    public final Byte get(int index) {
-        return adapt(values[index]);
-    }
-
     @Override
     public final int size() {
         return values().length;
@@ -102,13 +97,13 @@ private Builder(int initialCapacity) {
             this.size = 0;
         }
 
-        public synchronized final Builder add(byte item) {
+        public final Builder add(byte item) {
             ensureCapacity();
             array[size++] = item;
             return this;
         }
 
-        public synchronized final Builder add(byte... items) {
+        public final Builder add(byte... items) {
             // todo: systemcopy
             for (byte item : items) {
                 add(item);
@@ -117,28 +112,28 @@ public synchronized final Builder add(byte... items) {
         }
 
         @Override
-        public synchronized final Builder add(Byte item) {
+        public final Builder add(Byte item) {
             return add(adapt(item));
         }
 
         @Override
-        public synchronized final Builder add(Byte... items) {
+        public final Builder add(Byte... items) {
             for (Byte item : items) {
                 add(item);
             }
             return this;
         }
 
         @Override
-        public synchronized final Builder add(Iterable<Byte> items) {
+        public final Builder add(Iterable<Byte> items) {
             for (Byte item : items) {
                 add(item);
             }
             return this;
         }
 
         @Override
-        public synchronized final ByteArray build() {
+        public final ByteArray build() {
             return new ByteArray(takeAtSize());
         }
 

qst/src/main/java/io/deephaven/qst/array/CharArray.java

@@ -57,11 +57,6 @@ public final char[] values() {
         return values;
     }
 
-    @Override
-    public final Character get(int index) {
-        return adapt(values[index]);
-    }
-
     @Override
     public final int size() {
         return values().length;
@@ -103,13 +98,13 @@ private Builder(int initialCapacity) {
             this.size = 0;
         }
 
-        public synchronized final Builder add(char item) {
+        public final Builder add(char item) {
             ensureCapacity();
             array[size++] = item;
             return this;
         }
 
-        public synchronized final Builder add(char... items) {
+        public final Builder add(char... items) {
             // todo: systemcopy
             for (char item : items) {
                 add(item);
@@ -118,28 +113,28 @@ public synchronized final Builder add(char... items) {
         }
 
         @Override
-        public synchronized final Builder add(Character item) {
+        public final Builder add(Character item) {
             return add(adapt(item));
         }
 
         @Override
-        public synchronized final Builder add(Character... items) {
+        public final Builder add(Character... items) {
             for (Character item : items) {
                 add(item);
             }
             return this;
         }
 
         @Override
-        public synchronized final Builder add(Iterable<Character> items) {
+        public final Builder add(Iterable<Character> items) {
             for (Character item : items) {
                 add(item);
             }
             return this;
         }
 
         @Override
-        public synchronized final CharArray build() {
+        public final CharArray build() {
             return new CharArray(takeAtSize());
         }
 

qst/src/main/java/io/deephaven/qst/array/DoubleArray.java

@@ -33,11 +33,11 @@ public static Builder builder(int initialSize) {
         return new Builder(initialSize);
     }
 
-    private static double adapt(Double x) {
+    private static double unbox(Double x) {
         return x == null ? NULL_REPR : x;
     }
 
-    private static Double adapt(double x) {
+    private static Double box(double x) {
         return x == NULL_REPR ? null : x;
     }
 
@@ -56,11 +56,6 @@ public final double[] values() {
         return values;
     }
 
-    @Override
-    public final Double get(int index) {
-        return adapt(values[index]);
-    }
-
     @Override
     public final int size() {
         return values().length;
@@ -102,13 +97,13 @@ private Builder(int initialCapacity) {
             this.size = 0;
         }
 
-        public synchronized final Builder add(double item) {
+        public final Builder add(double item) {
             ensureCapacity();
             array[size++] = item;
             return this;
         }
 
-        public synchronized final Builder add(double... items) {
+        public final Builder add(double... items) {
             // todo: systemcopy
             for (double item : items) {
                 add(item);
@@ -117,28 +112,28 @@ public synchronized final Builder add(double... items) {
         }
 
         @Override
-        public synchronized final Builder add(Double item) {
-            return add(adapt(item));
+        public final Builder add(Double item) {
+            return add(unbox(item));
         }
 
         @Override
-        public synchronized final Builder add(Double... items) {
+        public final Builder add(Double... items) {
             for (Double item : items) {
                 add(item);
             }
             return this;
         }
 
         @Override
-        public synchronized final Builder add(Iterable<Double> items) {
+        public final Builder add(Iterable<Double> items) {
             for (Double item : items) {
                 add(item);
             }
             return this;
         }
 
         @Override
-        public synchronized final DoubleArray build() {
+        public final DoubleArray build() {
             return new DoubleArray(takeAtSize());
         }
 

qst/src/main/java/io/deephaven/qst/array/FloatArray.java

@@ -57,11 +57,6 @@ public final float[] values() {
         return values;
     }
 
-    @Override
-    public final Float get(int index) {
-        return adapt(values[index]);
-    }
-
     @Override
     public final int size() {
         return values().length;
@@ -103,13 +98,13 @@ private Builder(int initialCapacity) {
             this.size = 0;
         }
 
-        public synchronized final Builder add(float item) {
+        public final Builder add(float item) {
             ensureCapacity();
             array[size++] = item;
             return this;
         }
 
-        public synchronized final Builder add(float... items) {
+        public final Builder add(float... items) {
             // todo: systemcopy
             for (float item : items) {
                 add(item);
@@ -118,28 +113,28 @@ public synchronized final Builder add(float... items) {
         }
 
         @Override
-        public synchronized final Builder add(Float item) {
+        public final Builder add(Float item) {
             return add(adapt(item));
         }
 
         @Override
-        public synchronized final Builder add(Float... items) {
+        public final Builder add(Float... items) {
             for (Float item : items) {
                 add(item);
             }
             return this;
         }
 
         @Override
-        public synchronized final Builder add(Iterable<Float> items) {
+        public final Builder add(Iterable<Float> items) {
             for (Float item : items) {
                 add(item);
             }
             return this;
         }
 
         @Override
-        public synchronized final FloatArray build() {
+        public final FloatArray build() {
             return new FloatArray(takeAtSize());
         }