Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QST #715

Merged
merged 54 commits into from
Jul 29, 2021
Merged

QST #715

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
dc0b016
Added qst
devinrsmith Jul 20, 2021
6e3444d
Make qst array serializable
devinrsmith Jul 21, 2021
1d9930e
Hack around #875
devinrsmith Jul 21, 2021
c591b34
Updated graphviz with better library that can output to a bunch of fo…
devinrsmith Jul 22, 2021
722d5bb
fix formatting
devinrsmith Jul 22, 2021
ea002a6
KnownColumnTypes visitor isn't expecting custom
devinrsmith Jul 22, 2021
1e32fae
move known types to KnownColumnTypes
devinrsmith Jul 22, 2021
d71b669
remove ColumnHeaderX static builders
devinrsmith Jul 23, 2021
fe5b5f3
NewTable / ColumnHeader review updates
devinrsmith Jul 23, 2021
62bec7a
Default builder capacity
devinrsmith Jul 23, 2021
77d5b98
Table.of return type
devinrsmith Jul 23, 2021
336d6f6
Create io.deephaven.annotations
devinrsmith Jul 23, 2021
fadfa32
remove header visitor
devinrsmith Jul 23, 2021
b393666
Review response around merge
devinrsmith Jul 23, 2021
eb82265
depth-first -> post-order
devinrsmith Jul 23, 2021
eed873a
TableCreation.of -> merge
devinrsmith Jul 23, 2021
6741d6c
reorder visitors
devinrsmith Jul 23, 2021
23e16d2
remove Type.cast
devinrsmith Jul 23, 2021
e054de3
Check cast throws exception on invalid assign
devinrsmith Jul 23, 2021
f76ed5a
Scope of AllowNulls
devinrsmith Jul 23, 2021
1d1b470
remove iterable->collection methods
devinrsmith Jul 23, 2021
f74f396
remove generic array getters
devinrsmith Jul 23, 2021
63e4289
primitive array systemcopy
devinrsmith Jul 23, 2021
5d8abe9
use the ArrayBackedColumnSource helpers to construct the appropriate …
devinrsmith Jul 23, 2021
d66016b
Instant/DBDateTime
devinrsmith Jul 23, 2021
7df96cd
add explicit timeTable constructor
devinrsmith Jul 23, 2021
de11205
TimeTable id
devinrsmith Jul 23, 2021
cbdb7ff
TimeTable interval
devinrsmith Jul 23, 2021
41e3739
javadoc on Table deser
devinrsmith Jul 23, 2021
c18ca4a
remove overloads on Table
devinrsmith Jul 23, 2021
1af13eb
fix nanos
devinrsmith Jul 23, 2021
fcef3c6
remove selectable base restrictions
devinrsmith Jul 23, 2021
40d93e1
rename snapshot right to baseTable
devinrsmith Jul 23, 2021
7bfe725
TypeHelper
devinrsmith Jul 23, 2021
947c46b
move qst array constants into Util
devinrsmith Jul 23, 2021
191f0d0
make Ryan feel good
devinrsmith Jul 23, 2021
2b9ce00
Add primitive helpers to Column
devinrsmith Jul 23, 2021
5d1e488
null long
devinrsmith Jul 23, 2021
9fa65a6
move adapts to Util
devinrsmith Jul 23, 2021
3629369
remove graphviz from PR
devinrsmith Jul 23, 2021
5a45d03
row N varargs check
devinrsmith Jul 26, 2021
1c0a360
ColumnHeader param name
devinrsmith Jul 26, 2021
0595683
non-reflective primitive array builders
devinrsmith Jul 26, 2021
6344469
fix unit test, create getMemoryColumnSourceForBoolean
devinrsmith Jul 26, 2021
2a129d2
TableCreation javadoc
devinrsmith Jul 26, 2021
0f70db6
Fixup BooleanArray. Add addImpl for more efficient boxed varargs cons…
devinrsmith Jul 26, 2021
f2e5382
Revert "remove iterable->collection methods"
devinrsmith Jul 26, 2021
7dd0c2b
remove unused method
devinrsmith Jul 26, 2021
8253f12
Merge remote-tracking branch 'upstream/main' into tmp
devinrsmith Jul 29, 2021
0d8bee7
SnapshotTable does initial snapshot by default
devinrsmith Jul 29, 2021
64e5260
getBooleanMemoryColumnSource
devinrsmith Jul 29, 2021
062bafe
allow Head/TailTable w/ zero size
devinrsmith Jul 29, 2021
99613c4
rename qst Table -> TableSpec
devinrsmith Jul 29, 2021
597328d
Javadocs
devinrsmith Jul 29, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -104,17 +104,17 @@ protected void fillSparsePrevChunkUnordered(@NotNull final WritableChunk<? super

@Override
public void fillFromChunkByRanges(@NotNull OrderedKeys orderedKeys, Chunk<? extends Values> src) {
super.fillFromChunkByRanges(orderedKeys, src, DBTimeUtils::nanos);
super.<DBDateTime>fillFromChunkByRanges(orderedKeys, src, DBTimeUtils::nanos);
rcaudy marked this conversation as resolved.
Show resolved Hide resolved
}

@Override
void fillFromChunkByKeys(@NotNull OrderedKeys orderedKeys, Chunk<? extends Values> src) {
super.fillFromChunkByKeys(orderedKeys, src, DBTimeUtils::nanos);
super.<DBDateTime>fillFromChunkByKeys(orderedKeys, src, DBTimeUtils::nanos);
}

@Override
public void fillFromChunkUnordered(@NotNull FillFromContext context, @NotNull Chunk<? extends Values> src, @NotNull LongChunk<Attributes.KeyIndices> keys) {
super.fillFromChunkUnordered(src, keys, DBTimeUtils::nanos);
super.<DBDateTime>fillFromChunkUnordered(src, keys, DBTimeUtils::nanos);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public void testNanos() throws Exception{

assertEquals(jodaDateTime.getMillis()*1000000+123456, DBTimeUtils.nanos(dateTime));

assertEquals(io.deephaven.util.QueryConstants.NULL_LONG, DBTimeUtils.nanos(null));
assertEquals(io.deephaven.util.QueryConstants.NULL_LONG, DBTimeUtils.nanos((DBDateTime) null));
}

public void testMidnightConversion() throws Exception{
Expand Down