Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patterns] Co19 tests - add tests #1401

Closed
itsjustkevin opened this issue Aug 19, 2022 · 6 comments
Closed

[Patterns] Co19 tests - add tests #1401

itsjustkevin opened this issue Aug 19, 2022 · 6 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@itsjustkevin
Copy link

No description provided.

@sgrekhov
Copy link
Contributor

@itsjustkevin @eernstg is this a right feature specification link for Patterns? https://github.com/dart-lang/language/blob/master/working/0546-patterns/patterns-feature-specification.md

@eernstg
Copy link
Member

eernstg commented Aug 22, 2022

Yes!

@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Aug 22, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 25, 2022
@sgrekhov
dart-lang#1401. [Patterns] Logical-or tests added
bc58e06
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 26, 2022
@sgrekhov
dart-lang#1401. More test cases added
811da27
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 26, 2022
@sgrekhov
dart-lang#1401. Logical-or tests fixed
c4bf30a
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 31, 2022
@sgrekhov
dart-lang#1401. [Patterns] Missing log added
27f5593
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 3, 2022
@sgrekhov
dart-lang#1401. [Patterns] Logical-or tests improved
037c1a5
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 3, 2022
@sgrekhov
dart-lang#1401. Logical-or tests fixed
208055c
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 3, 2022
@sgrekhov
dart-lang#1401. logical_or_A04_t02.dart test fixed
ce14909
eernstg pushed a commit that referenced this issue Nov 3, 2022
@sgrekhov
#1401. [Patterns] Logical-or tests added (#1520)
36cc25d 
Authored by @sgrekhov.

Add logical-or tests. Using a log to detect execution of getters during a matching step.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 4, 2022
@sgrekhov
dart-lang#1401. [Patterns] logical-and pattern tests added
7b43d58
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 7, 2022
@sgrekhov
dart-lang#1401. [Patterns] logical-and pattern tests improved
d0b6736
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 7, 2022
@sgrekhov
dart-lang#1401. [Patterns] logical-and pattern tests fixed
293d157
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 7, 2022
@sgrekhov
dart-lang#1401. [Patterns] logical-and pattern tests fixed
9e52099
eernstg pushed a commit that referenced this issue Nov 7, 2022
@sgrekhov
#1401. [Patterns] logical-and pattern tests added (#1534)
31e395d 
Authored by @sgrekhov.

Logical-and pattern tests added.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 7, 2022
@sgrekhov
dart-lang#1401. [Patterns] relational pattern tests added
4245f45
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 7, 2022
@sgrekhov @athomas
[co19] Roll co19 to 36cc25de009198a8516be7f12ac5b61069656d09
87cb9a6 
2022-11-03 [email protected] dart-lang/co19#1401. [Patterns] Logical-or tests added (dart-lang/co19#1520)
2022-11-02 [email protected] Fixes dart-lang/co19#1528. Update on clauses ambiguity tests (dart-lang/co19#1533)
2022-10-31 [email protected] dart-lang/co19#1399. [Records] Check a big record with a large number of positional fields (dart-lang/co19#1518)

Change-Id: I7d87440512113230d5d8af2737684074e6906711
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/267825
Reviewed-by: Alexander Thomas <[email protected]>
chloestefantsova pushed a commit that referenced this issue Nov 8, 2022
@sgrekhov
#1401. [Patterns] relational pattern tests added (#1535)
19439c0
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 8, 2022
@sgrekhov
dart-lang#1401. [Patterns] cast, null-assert and null-check patterns …
e25f784 
…tests added
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 8, 2022
@sgrekhov
dart-lang#1401. Typo fixed
08907f8
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 8, 2022
@sgrekhov
dart-lang#1401. Added ; at the end of expression
f4323f9
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 9, 2022
@sgrekhov
dart-lang#1401. [Patterns] Constant pattern tests added
c18e9d2
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 9, 2022
@sgrekhov
dart-lang#1401. Expect error for Symbol in a constant pattern
aad1193
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 10, 2022
@sgrekhov
dart-lang#1401. Add more erroneous const patterns
b88e8d8
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 10, 2022
@sgrekhov
dart-lang#1401. [Patterns] Variable pattern tests added
56afcc8
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 10, 2022
@sgrekhov
dart-lang#1401. More test cases for invalid constant patterns
5a7ee1b
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 10, 2022
@sgrekhov
dart-lang#1401. More test cases for valid constant patterns
9e23b28
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 11, 2022
@sgrekhov
dart-lang#1401. Variable pattern tests updated
f1c9259
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Mar 23, 2023
@sgrekhov @athomas
[co19] Roll co19 to c1aef806ebbc20bedee6043bf517785f33fd1094
9640bef 
2023-03-23 [email protected] Roll failures fixed (dart-lang/co19#1962)
2023-03-23 [email protected] Fixes dart-lang/co19#1937. Add `@dart=2.19` to class implementing `LinkedHashSet` (dart-lang/co19#1961)
2023-03-23 [email protected] dart-lang/co19#1874. Update LanguageFeatures/nnbd/weak/overriding tests to work with class modifiers (dart-lang/co19#1960)
2023-03-22 [email protected] Minor fixes to execution_pattern_for_in_{element,statement}_A01_t01 (dart-lang/co19#1958)
2023-03-22 [email protected] dart-lang/co19#1401. Tests for invocation keys (dart-lang/co19#1950)
2023-03-22 [email protected] Fixes dart-lang/co19#1951. Don't use fixed port number (dart-lang/co19#1952)
2023-03-22 [email protected] Fixes dart-lang/co19#1955. Use non-matching rest elements in matching_list_A02_t01.dart (dart-lang/co19#1957)
2023-03-22 [email protected] Fixes dart-lang/co19#1940. Add `final` modifier to classes extending `Struct` and `Union` (dart-lang/co19#1956)
2023-03-21 [email protected] Fixes dart-lang/co19#1928. Replace `extends Iterator` by `implements Iterator` (dart-lang/co19#1953)
2023-03-21 [email protected] Fixes dart-lang/co19#1944. Replace `extends StreamSubscription` by `implements StreamSubscription` (dart-lang/co19#1954)
2023-03-20 [email protected] Fixes dart-lang/co19#1946. Duplicated test removed (dart-lang/co19#1948)
2023-03-20 [email protected] Fixes dart-lang/co19#1947. Move nnbd-strong runtime checks in a separate test (dart-lang/co19#1949)
2023-03-20 [email protected] dart-lang/co19#1401. Matching tests for map pattern (dart-lang/co19#1929)
2023-03-17 [email protected] dart-lang/co19#1401. Call insertions tests added (dart-lang/co19#1945)

Change-Id: I27c375f32b02e8bea78562adb58ef5da1b629a45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290764
Reviewed-by: Alexander Thomas <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Mar 24, 2023
@sgrekhov
dart-lang#1401. If- and for-elements tests for maps and sets added
150b776
@sgrekhov
Copy link
Contributor

Reopened. Spec for exaustiveness is ready for testing. Need to add appropriate tests

@sgrekhov sgrekhov reopened this Mar 27, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Mar 29, 2023
@sgrekhov
dart-lang#1401. Exhaustiveness tests added
066b7e8
eernstg pushed a commit that referenced this issue Mar 30, 2023
@sgrekhov
#1401. If- and for-elements tests for maps and sets added (#1967)
d1d9d70 
Add tests about If- and for-elements for maps and sets
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Mar 31, 2023
@sgrekhov @athomas
[co19] Roll co19 to 7edd464c87e1cd453d7c4410cf2ee1240a6320d7
cbf64d7 
2023-03-30 [email protected] Fixes dart-lang/co19#1964. Split matching_map_A01_t01.dart into two tests. The second one is for sound nullability only (dart-lang/co19#1965)
2023-03-30 [email protected] dart-lang/co19#1401. If- and for-elements tests for maps and sets added (dart-lang/co19#1967)
2023-03-30 [email protected] Remove ProcessInfo constructor test (dart-lang/co19#1975)
2023-03-29 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.10.0 to 3.11.0 (dart-lang/co19#1971)
2023-03-29 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.3.0 to 3.5.0 (dart-lang/co19#1970)
2023-03-28 [email protected] Fixes dart-lang/co19#1972. Add nnbd-strong flag to some map-pattern runtime tests (dart-lang/co19#1973)
2023-03-27 [email protected] Fix IntPtrArray_A01_t01.dart. Remove platform-depended code (dart-lang/co19#1969)

Change-Id: I23b05e414ef7517ee198e426fbf9b85165ce89b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292300
Reviewed-by: Alexander Thomas <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Mar 31, 2023
@sgrekhov
dart-lang#1401. Additional test for the rest element of a list pattern
3a8e419
eernstg pushed a commit that referenced this issue Mar 31, 2023
@sgrekhov
#1401. Additional test for the rest element of a list pattern (#1980)
fa686fc
eernstg pushed a commit that referenced this issue Apr 3, 2023
@sgrekhov
#1401. Exhaustiveness tests added (#1974)
a6665ad 
Exhaustiveness tests added
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 4, 2023
@sgrekhov
dart-lang#1401. Exhaustiveness algorithm tests
44e3ea3
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 4, 2023
@sgrekhov
[co19] Roll co19 to cd2670bfc29f0be99ca9d3e079f314f686680afc
3f87b7f 
2023-04-04 [email protected] Fixes dart-lang/co19#1985. Roll failures fixed (dart-lang/co19#1986)
2023-04-04 [email protected] Fixes dart-lang/co19#1983. Typo fixed in type_inference_A22_t01.dart (dart-lang/co19#1984)
2023-04-03 [email protected] Fixes dart-lang/co19#1978. Add processing of HINT.UNREACHABLE_SWITCH_CASE (dart-lang/co19#1982)
2023-04-03 [email protected] dart-lang/co19#1401. Exhaustiveness tests added (dart-lang/co19#1974)
2023-03-31 [email protected] Fixes dart-lang/co19#1976. Runtime errors fixed (dart-lang/co19#1981)
2023-03-31 [email protected] Fixes dart-lang/co19#1976. Update map pattern tests according to the new matching rules (dart-lang/co19#1977)
2023-03-31 [email protected] dart-lang/co19#1401. Additional test for the rest element of a list pattern (dart-lang/co19#1980)

Change-Id: I5be25e8f96d081028d68b5086c33b7432f1c8a66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292883
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
eernstg pushed a commit that referenced this issue Apr 4, 2023
@sgrekhov
#1401. Exhaustiveness algorithm tests (#1987)
4564cc4
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 5, 2023
@eernstg
[co19] Roll co19 to 866b487c88e24b6a02e9fd95de4f4982aba34a32
ae35225 
2023-04-05 [email protected] Fixes dart-lang/co19#1988. Typo in exhaustiveness_A01_t17.dart fixed (dart-lang/co19#1992)
2023-04-05 [email protected] Fixes dart-lang/co19#1989. Typo in object_A03_t01.dart fixed (dart-lang/co19#1993)
2023-04-04 [email protected] dart-lang/co19#1401. Exhaustiveness algorithm tests (dart-lang/co19#1987)

Change-Id: I89642761f4ff746dfdaba7d586f6c5c1a5e2158a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/293540
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Auto-Submit: Erik Ernst <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 6, 2023
@sgrekhov
dart-lang#1401. Exhaustiveness tests updated and fixed
b7bea88
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 6, 2023
@sgrekhov
dart-lang#1401. Exhaustiveness tests updated and new ones added
9919180
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 7, 2023
@sgrekhov
dart-lang#1401. Exhaustiveness of custom classes that implement List
77fb084
eernstg pushed a commit that referenced this issue Apr 11, 2023
@sgrekhov
#1401. Exhaustiveness tests fixed and new ones added (#2019)
c01fbd7 
Update and fix exhaustiveness tests. In particular, test exhaustiveness of custom classes that implement `List`, including implementations whose `length` can be negative.
@sgrekhov
Copy link
Contributor

Completed

@eernstg
Copy link
Member

eernstg commented Apr 13, 2023

Thump! says the big door as it is closed. Thanks for the great work on creating all those tests!

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 14, 2023
@sgrekhov @athomas
[co19] Roll co19 to c01fbd751c060650b6582523a7751b83777026c3
b5ac282 
2023-04-11 [email protected] dart-lang/co19#1401. Exhaustiveness tests fixed and new ones added (dart-lang/co19#2019)
2023-04-11 [email protected] Fixes dart-lang/co19#2006. `Pointer` can have top types as type arguments (dart-lang/co19#2013)
2023-04-11 [email protected] Fixes dart-lang/co19#2010. Fix exhaustiveness tests for a cast-pattern (dart-lang/co19#2018)
2023-04-07 [email protected] Fixes dart-lang/co19#2004. Update expected errors locations for CFE (dart-lang/co19#2011)
2023-04-07 [email protected] Fixes dart-lang/co19#2005. DynamicLibrary.process() is supported on Windows (dart-lang/co19#2012)
2023-04-07 [email protected] Fixes dart-lang/co19#2007. Fix UintPtr_A01_t01.dart not to fail on 32-bit platforms (dart-lang/co19#2014)
2023-04-07 [email protected] Fixes dart-lang/co19#2008. Split pattern_context_A01_t01.dart test to multiple methods (dart-lang/co19#2015)
2023-04-07 [email protected] Fixes dart-lang/co19#2009. Update scope_A01_t01.dart according to the current CFE behavior (dart-lang/co19#2016)

Change-Id: I5b43a5c5f133dded30564749b38f6a0c965b62fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/295281
Reviewed-by: Alexander Thomas <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 1, 2023
@sgrekhov
dart-lang#1401. Async for-in tests added
1d7920b
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 2, 2023
@sgrekhov
dart-lang#1401. More async for-in statement tests added
276295a
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 3, 2023
@sgrekhov
dart-lang#1401. Async for-in element tests added
34b9ef2
eernstg pushed a commit that referenced this issue May 3, 2023
@sgrekhov
#1401. Async for-in tests for patterns (#2032)
7c4a94f 
Add async for-in tests. Note that some tests contain syntax errors intentionally, which cases the spec_parser run to fail.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 4, 2023
@sgrekhov @athomas
[co19] Roll co19 to 794313da70f2b8c1150ffcbf2fbf8746649ab09f
6d90390 
2023-05-04 [email protected] Fixes dart-lang/co19#2034. Fix roll failures, add issues numbers (dart-lang/co19#2035)
2023-05-03 [email protected] dart-lang/co19#1401. Async for-in tests for patterns (dart-lang/co19#2032)
2023-04-28 [email protected] dart-lang/co19#1959. Grammar tests added (dart-lang/co19#2031)
2023-04-28 [email protected] dart-lang/co19#1959. Versioning tests added (dart-lang/co19#2029)

Change-Id: Ic29913ebd7260c4069e6baa27a797219ce12d956
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/301440
Reviewed-by: Alexander Thomas <[email protected]>
eernstg pushed a commit that referenced this issue May 8, 2023
@sgrekhov
#1401. Async for-in element tests added (#2033)
238bd87 
Async for-in element tests added. Note that  LanguageFeatures/Patterns/execution_pattern_await_for_in_element_A02_t0{1,2,3}.dart contain intentional syntax errors.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 12, 2023
@sgrekhov
dart-lang#1401. Inline classes syntax tests updated and missing one a…
82aee1d 
…dded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgrekhov @eernstg @itsjustkevin