Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LanguageFeatures/Patterns/matching_list_A01_t01 #1947

Closed
alexmarkov opened this issue Mar 17, 2023 · 1 comment
Closed

LanguageFeatures/Patterns/matching_list_A01_t01 #1947

alexmarkov opened this issue Mar 17, 2023 · 1 comment
Assignees
@sgrekhov
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@alexmarkov
Copy link

This test is not valid without sound null safety (in weak mode) as it assumes that <int?>[] is not matched against <int>[] pattern:

co19/LanguageFeatures/Patterns/matching_list_A01_t01.dart

Line 100 in 3f7c689

Expect.equals("no match", test1(<int?>[]));

co19/LanguageFeatures/Patterns/matching_list_A01_t01.dart

Lines 63 to 64 in 3f7c689

case <int>[]:
return "match-1";

@alexmarkov alexmarkov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Mar 17, 2023
@alexmarkov
Copy link
Author

Also LanguageFeatures/Patterns/matching_list_A01_t02.

@sgrekhov sgrekhov self-assigned this Mar 20, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Mar 20, 2023
@sgrekhov
Fixes dart-lang#1947. Move nnbd-strong runtime checks in a separate test
04bd65b
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Mar 23, 2023
@sgrekhov @athomas
[co19] Roll co19 to c1aef806ebbc20bedee6043bf517785f33fd1094
9640bef 
2023-03-23 [email protected] Roll failures fixed (dart-lang/co19#1962)
2023-03-23 [email protected] Fixes dart-lang/co19#1937. Add `@dart=2.19` to class implementing `LinkedHashSet` (dart-lang/co19#1961)
2023-03-23 [email protected] dart-lang/co19#1874. Update LanguageFeatures/nnbd/weak/overriding tests to work with class modifiers (dart-lang/co19#1960)
2023-03-22 [email protected] Minor fixes to execution_pattern_for_in_{element,statement}_A01_t01 (dart-lang/co19#1958)
2023-03-22 [email protected] dart-lang/co19#1401. Tests for invocation keys (dart-lang/co19#1950)
2023-03-22 [email protected] Fixes dart-lang/co19#1951. Don't use fixed port number (dart-lang/co19#1952)
2023-03-22 [email protected] Fixes dart-lang/co19#1955. Use non-matching rest elements in matching_list_A02_t01.dart (dart-lang/co19#1957)
2023-03-22 [email protected] Fixes dart-lang/co19#1940. Add `final` modifier to classes extending `Struct` and `Union` (dart-lang/co19#1956)
2023-03-21 [email protected] Fixes dart-lang/co19#1928. Replace `extends Iterator` by `implements Iterator` (dart-lang/co19#1953)
2023-03-21 [email protected] Fixes dart-lang/co19#1944. Replace `extends StreamSubscription` by `implements StreamSubscription` (dart-lang/co19#1954)
2023-03-20 [email protected] Fixes dart-lang/co19#1946. Duplicated test removed (dart-lang/co19#1948)
2023-03-20 [email protected] Fixes dart-lang/co19#1947. Move nnbd-strong runtime checks in a separate test (dart-lang/co19#1949)
2023-03-20 [email protected] dart-lang/co19#1401. Matching tests for map pattern (dart-lang/co19#1929)
2023-03-17 [email protected] dart-lang/co19#1401. Call insertions tests added (dart-lang/co19#1945)

Change-Id: I27c375f32b02e8bea78562adb58ef5da1b629a45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290764
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @alexmarkov