-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Class modifiers] The Function
class will be final in Dart 3.0
#1874
Comments
You may be able to find some more here: |
@mit-mit the log is unavailable for me. Could you, please, provide a link to the gerrit CL? |
Sorry about that. It's here: https://dart-review.googlesource.com/c/sdk/+/284185?tab=checks And the test results: https://ci.chromium.org/ui/p/dart/builders/try/analyzer-linux-release-try/63852/overview |
Now I see. Thank you! |
If you don't mind I'll fix if when CL is landed |
… work with class modifiers
2023-03-23 [email protected] Roll failures fixed (dart-lang/co19#1962) 2023-03-23 [email protected] Fixes dart-lang/co19#1937. Add `@dart=2.19` to class implementing `LinkedHashSet` (dart-lang/co19#1961) 2023-03-23 [email protected] dart-lang/co19#1874. Update LanguageFeatures/nnbd/weak/overriding tests to work with class modifiers (dart-lang/co19#1960) 2023-03-22 [email protected] Minor fixes to execution_pattern_for_in_{element,statement}_A01_t01 (dart-lang/co19#1958) 2023-03-22 [email protected] dart-lang/co19#1401. Tests for invocation keys (dart-lang/co19#1950) 2023-03-22 [email protected] Fixes dart-lang/co19#1951. Don't use fixed port number (dart-lang/co19#1952) 2023-03-22 [email protected] Fixes dart-lang/co19#1955. Use non-matching rest elements in matching_list_A02_t01.dart (dart-lang/co19#1957) 2023-03-22 [email protected] Fixes dart-lang/co19#1940. Add `final` modifier to classes extending `Struct` and `Union` (dart-lang/co19#1956) 2023-03-21 [email protected] Fixes dart-lang/co19#1928. Replace `extends Iterator` by `implements Iterator` (dart-lang/co19#1953) 2023-03-21 [email protected] Fixes dart-lang/co19#1944. Replace `extends StreamSubscription` by `implements StreamSubscription` (dart-lang/co19#1954) 2023-03-20 [email protected] Fixes dart-lang/co19#1946. Duplicated test removed (dart-lang/co19#1948) 2023-03-20 [email protected] Fixes dart-lang/co19#1947. Move nnbd-strong runtime checks in a separate test (dart-lang/co19#1949) 2023-03-20 [email protected] dart-lang/co19#1401. Matching tests for map pattern (dart-lang/co19#1929) 2023-03-17 [email protected] dart-lang/co19#1401. Call insertions tests added (dart-lang/co19#1945) Change-Id: I27c375f32b02e8bea78562adb58ef5da1b629a45 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290764 Reviewed-by: Alexander Thomas <[email protected]>
In pre-3.0 code the
Function
class can be implemented, extended and (probably) mixed in, it's just ignored and has absolutely no effect.In 3.0 code, the
Function
class will have afinal
modifier which prevents all of the above.The following tests seem to be affected by that (according to a
grep
):If there are more examples (didn't find any
implements
?) or ones that go through indirections, say something likeimplements IdAlias<Function>
withtypedef IdAlias<T> = T;
, then they might also need fixing.The text was updated successfully, but these errors were encountered: