Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1874. Update LanguageFeatures/nnbd/weak/overriding tests to work with class modifiers #1960

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

sgrekhov
Copy link
Contributor

This simple change enables a large bunch of tests to work with class modifiers.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit ba5ea0e into dart-lang:master Mar 23, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 23, 2023
2023-03-23 [email protected] Roll failures fixed (dart-lang/co19#1962)
2023-03-23 [email protected] Fixes dart-lang/co19#1937. Add `@dart=2.19` to class implementing `LinkedHashSet` (dart-lang/co19#1961)
2023-03-23 [email protected] dart-lang/co19#1874. Update LanguageFeatures/nnbd/weak/overriding tests to work with class modifiers (dart-lang/co19#1960)
2023-03-22 [email protected] Minor fixes to execution_pattern_for_in_{element,statement}_A01_t01 (dart-lang/co19#1958)
2023-03-22 [email protected] dart-lang/co19#1401. Tests for invocation keys (dart-lang/co19#1950)
2023-03-22 [email protected] Fixes dart-lang/co19#1951. Don't use fixed port number (dart-lang/co19#1952)
2023-03-22 [email protected] Fixes dart-lang/co19#1955. Use non-matching rest elements in matching_list_A02_t01.dart (dart-lang/co19#1957)
2023-03-22 [email protected] Fixes dart-lang/co19#1940. Add `final` modifier to classes extending `Struct` and `Union` (dart-lang/co19#1956)
2023-03-21 [email protected] Fixes dart-lang/co19#1928. Replace `extends Iterator` by `implements Iterator` (dart-lang/co19#1953)
2023-03-21 [email protected] Fixes dart-lang/co19#1944. Replace `extends StreamSubscription` by `implements StreamSubscription` (dart-lang/co19#1954)
2023-03-20 [email protected] Fixes dart-lang/co19#1946. Duplicated test removed (dart-lang/co19#1948)
2023-03-20 [email protected] Fixes dart-lang/co19#1947. Move nnbd-strong runtime checks in a separate test (dart-lang/co19#1949)
2023-03-20 [email protected] dart-lang/co19#1401. Matching tests for map pattern (dart-lang/co19#1929)
2023-03-17 [email protected] dart-lang/co19#1401. Call insertions tests added (dart-lang/co19#1945)

Change-Id: I27c375f32b02e8bea78562adb58ef5da1b629a45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290764
Reviewed-by: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov deleted the co19-1874-1 branch July 18, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants