Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Class modifiers] Add tests for class modifiers #1959

Closed
sgrekhov opened this issue Mar 23, 2023 · 1 comment
Closed

[Class modifiers] Add tests for class modifiers #1959

sgrekhov opened this issue Mar 23, 2023 · 1 comment
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@sgrekhov
Copy link
Contributor

Add tests for class modifiers language feature
@sgrekhov sgrekhov self-assigned this Mar 23, 2023
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Mar 24, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 7, 2023
@sgrekhov
dart-lang#1959. Tests for syntax and basic restrictions
6ef01bf
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 13, 2023
@sgrekhov
dart-lang#1959. More basic and mixin restrictions tests
c9923e2
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 13, 2023
@sgrekhov
dart-lang#1959. Enums tests updated. Duplicated checks removed
17fd1dc
eernstg pushed a commit that referenced this issue Apr 17, 2023
@sgrekhov
#1959. Tests for syntax and basic restrictions (#2017)
c966bce 
Add tests for syntax and basic restrictions.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 17, 2023
@sgrekhov
dart-lang#1959. Test for restrictions of valid combinations of modifiers
91df6c3
eernstg pushed a commit that referenced this issue Apr 17, 2023
@sgrekhov
#1959. More basic and mixin restrictions tests (#2021)
a740be1 
Add more basic and mixin restrictions tests.
eernstg pushed a commit that referenced this issue Apr 19, 2023
@sgrekhov
#1959. Test valid combinations of modifiers. Part 1 (#2023)
4b81577 
Test for restrictions of valid combinations of modifiers.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 19, 2023
@sgrekhov
dart-lang#1959. Test valid combinations of modifiers. Part 2
f8cdf13
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 20, 2023
@sgrekhov
dart-lang#1959. More valid combinations of modifiers tests added
1106dde
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 21, 2023
@sgrekhov
dart-lang#1959. Test valid combinations of modifiers. Part 3
1dad722
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 24, 2023
@sgrekhov
[co19] Roll co19 to 4b8157719cdcb99ee7380c920551786b6383f961
92239e6 
2023-04-19 [email protected] dart-lang/co19#1959. Test valid combinations of modifiers. Part 1 (dart-lang/co19#2023)
2023-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.0 to 3.5.2 (dart-lang/co19#2022)
2023-04-17 [email protected] dart-lang/co19#1959. More basic and mixin restrictions tests (dart-lang/co19#2021)
2023-04-17 [email protected] dart-lang/co19#1959. Tests for syntax and basic restrictions (dart-lang/co19#2017)

Change-Id: I0d27a6b3504eb13351e72d8dac6281ff0aa52fc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296802
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
eernstg pushed a commit that referenced this issue Apr 24, 2023
@sgrekhov
#1959. Test valid combinations of modifiers. Part 2 (#2024)
07ad974 
Add tests about valid combinations of modifiers.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 24, 2023
@sgrekhov
dart-lang#1959. Versioning tests added
4764d11
eernstg pushed a commit that referenced this issue Apr 25, 2023
@sgrekhov
#1959. Test valid combinations of modifiers. Part 3 (#2025)
fc31789 
Test valid combinations of modifiers. Part 3
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 26, 2023
@sgrekhov
dart-lang#1959. Tests for class modifiers restrictions and type aliases
7bb5f61
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Apr 28, 2023
@sgrekhov
dart-lang#1959. Grammar tests added
b8bcb3d
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 28, 2023
@sgrekhov
[co19] Roll co19 to fc31789eadd5a664fe25e69cb966555e78a65d0d
cda6ab5 
2023-04-25 [email protected] dart-lang/co19#1959. Test valid combinations of modifiers. Part 3 (dart-lang/co19#2025)
2023-04-25 [email protected] Fixes dart-lang/co19#2027. Hint expectation added (dart-lang/co19#2028)
2023-04-24 [email protected] dart-lang/co19#1959. Test valid combinations of modifiers. Part 2 (dart-lang/co19#2024)

Change-Id: I32326cf0be0e3ac7a0ac901ea476213083307355
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/299520
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
eernstg pushed a commit that referenced this issue Apr 28, 2023
@sgrekhov
#1959. Versioning tests added (#2029)
80f4d80 
Add tests about rules relating class modifiers and language versions.
eernstg pushed a commit that referenced this issue Apr 28, 2023
@sgrekhov
#1959. Grammar tests added (#2031)
be5c6fa 
Add grammar tests
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 4, 2023
@sgrekhov @athomas
[co19] Roll co19 to 794313da70f2b8c1150ffcbf2fbf8746649ab09f
6d90390 
2023-05-04 [email protected] Fixes dart-lang/co19#2034. Fix roll failures, add issues numbers (dart-lang/co19#2035)
2023-05-03 [email protected] dart-lang/co19#1401. Async for-in tests for patterns (dart-lang/co19#2032)
2023-04-28 [email protected] dart-lang/co19#1959. Grammar tests added (dart-lang/co19#2031)
2023-04-28 [email protected] dart-lang/co19#1959. Versioning tests added (dart-lang/co19#2029)

Change-Id: Ic29913ebd7260c4069e6baa27a797219ce12d956
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/301440
Reviewed-by: Alexander Thomas <[email protected]>
chloestefantsova pushed a commit that referenced this issue May 10, 2023
@sgrekhov
#1959. Tests for class modifiers restrictions and type aliases (#2030)
56fc2a7 
* #1959. Tests for class modifiers restrictions and type aliases

* More tests for type aliases

* More tests for type aliases

* Implement review changes
@sgrekhov
Copy link
Contributor Author

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov