#1959. Tests for class modifiers restrictions and type aliases #2030
Conversation
|
|
||
| typedef LocalTypedefSealedClass = SealedClass; | ||
|
|
||
| mixin MixinOnLocalTypedefSealedClasson LocalTypedefSealedClass {} |
There was a problem hiding this comment.
Is on missing between MixinOnLocalTypedefSealedClasson and LocalTypedefSealedClass?
| // [cfe] unspecified | ||
|
|
||
| base mixin class MixinClassIndirectlyImplementsBaseClass implements TypedefWithBaseMixinClass {} | ||
| // ^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Should the error location marker ^^^ be extended for the entire TypedefWithBaseMixinClass?
| /// marked base, final or sealed. | ||
| /// | ||
| /// @description Check that it is a compile-time error if a declaration is not | ||
| /// `base`, `final` or `sealed` and has a superdeclaration marked `final`. Test |
There was a problem hiding this comment.
If I understood the spec correctly, a declaration that has a proper superdeclaration marked final is a compile-time error regardless of the declaration itself having base, final, or sealed modifiers. Some exceptions may apply, based on the version of the libraries and them being core libraries.
There was a problem hiding this comment.
final class can be extended by final, base or sealed classes defined in the same library. One of the tests that checks it (and passes) is https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Class-modifiers/basic_restrictions_A02_t07.dart
There was a problem hiding this comment.
Got it. Thanks for the clarification!
| /// marked base, final or sealed. | ||
| /// | ||
| /// @description Check that it is a compile-time error if a declaration is not | ||
| /// `base`, `final` or `sealed` and has a superdeclaration marked `final`. Test |
| /// marked base, final or sealed. | ||
| /// | ||
| /// @description Check that it is a compile-time error if a declaration is not | ||
| /// `base`, `final` or `sealed` and has a superdeclaration marked `final`. Test |
| /// marked base, final or sealed. | ||
| /// | ||
| /// @description Check that it is a compile-time error if a declaration is not | ||
| /// `base`, `final` or `sealed` and has a superdeclaration marked `final`. Test |
| /// marked base, final or sealed. | ||
| /// | ||
| /// @description Check that it is a compile-time error if a declaration is not | ||
| /// `base`, `final` or `sealed` and has a superdeclaration marked `sealed`. Test |
There was a problem hiding this comment.
If I understood the specification correctly, the restriction imposed by the sealed declarations is that they can be extended only in the same library they are declared. It is a compile-time error to use them as superdeclarations outside of their own library, regardless of the modifiers base, final, and sealed.
There was a problem hiding this comment.
Indeed. And we have basic_restrictions_A01_t01.dart (basic_restrictions_A01_t09.dart for type aliases) testsing that it's an error to extend a sealed class outside of its library by a class with any modifier. Deleted this test. Thank you for noticing
|
|
||
| typedef LocalTypedefSealedClass = SealedClass; | ||
|
|
||
| mixin MixinOnLocalTypedefSealedClasson LocalTypedefSealedClass {} |
| // [cfe] unspecified | ||
|
|
||
| base mixin class MixinClassIndirectlyImplementsBaseClass implements TypedefWithBaseMixinClass {} | ||
| // ^^^^^^^^^^^^^^^^^^ |
| /// marked base, final or sealed. | ||
| /// | ||
| /// @description Check that it is a compile-time error if a declaration is not | ||
| /// `base`, `final` or `sealed` and has a superdeclaration marked `final`. Test |
There was a problem hiding this comment.
final class can be extended by final, base or sealed classes defined in the same library. One of the tests that checks it (and passes) is https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Class-modifiers/basic_restrictions_A02_t07.dart
| /// marked base, final or sealed. | ||
| /// | ||
| /// @description Check that it is a compile-time error if a declaration is not | ||
| /// `base`, `final` or `sealed` and has a superdeclaration marked `sealed`. Test |
There was a problem hiding this comment.
Indeed. And we have basic_restrictions_A01_t01.dart (basic_restrictions_A01_t09.dart for type aliases) testsing that it's an error to extend a sealed class outside of its library by a class with any modifier. Deleted this test. Thank you for noticing
|
Merge conflicts resolved. Please merge this PR |
No description provided.