Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1959. Test valid combinations of modifiers. Part 3 #2025

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of typos in 'description'.

@sgrekhov
Copy link
Contributor Author

Typos fixed. Please take another look

@sgrekhov sgrekhov requested a review from eernstg April 25, 2023 08:22
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit fc31789 into dart-lang:master Apr 25, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 28, 2023
2023-04-25 [email protected] dart-lang/co19#1959. Test valid combinations of modifiers. Part 3 (dart-lang/co19#2025)
2023-04-25 [email protected] Fixes dart-lang/co19#2027. Hint expectation added (dart-lang/co19#2028)
2023-04-24 [email protected] dart-lang/co19#1959. Test valid combinations of modifiers. Part 2 (dart-lang/co19#2024)

Change-Id: I32326cf0be0e3ac7a0ac901ea476213083307355
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/299520
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov deleted the co19-1959-5 branch July 18, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants