Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix firefox default size system test #30759

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Dec 13, 2024

  • Closes n/a

Additional details

After merging in the firefox size fix from develop, the default_size.cy.js spec started failing since it was not assuming the size fix. To resolve the failure, the firefox size workaround was removed.

Steps to test

n/a

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented Dec 13, 2024

cypress    Run #58865

Run Properties:  status check passed Passed #58865  •  git commit ecbc65f836: test: fix default size system test
Project cypress
Branch Review mschile/firefox_default_size_system_test
Run status status check passed Passed #58865
Run duration 17m 31s
Commit git commit ecbc65f836: test: fix default size system test
Committer Matthew Schile
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 1326
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 29383
View all changes introduced in this branch ↗︎
UI Coverage  46.07%
  Untested elements 187  
  Tested elements 164  
Accessibility  92.55%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 894  

@mschile mschile changed the title test: fix default size system test test: fix firefox default size system test Dec 13, 2024
@mschile mschile merged commit 6531828 into release/14.0.0 Dec 13, 2024
84 of 86 checks passed
@mschile mschile deleted the mschile/firefox_default_size_system_test branch December 13, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants