Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: update @electron/rebuild to 3.7.1 #30633

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Nov 17, 2024

Additional details

This PR builds on updates for release/14.0.0.

@electron/[email protected] is updated to @electron/[email protected] (current latest) in packages/server.

This removes the dependency on [email protected] and allows [email protected] to be used.

This in turn allows the default Python 3.12 version to be used on Ubuntu 24.*, removing restrictions and the need for downgrading to Python 3.11. On Windows it relieves the need to install a Windows 10 SDK additionally. Building Cypress from source is then possible, without errors from node-gyp and without resorting to these workarounds.

@electron/rebuild purpose:

This executable rebuilds native Node.js modules against the version of Node.js that your Electron project is using. This allows you to use native Node.js modules in Electron apps without your system version of Node.js matching exactly (which is often not the case, and sometimes not even possible).

Steps to test

Follow the instructions in CONTRIBUTING > Requirements including the use of Node.js v20.18.0, with the exception of special instructions for Python 3.11, which should be omitted.

git clone https://github.com/cypress-io/cypress
cd cypress
n auto # or set Node.js manually
git clean -xfd
yarn

Confirm that the installation was successful and that the following log sequence shows no errors between the steps:

[5/6] Building fresh packages...
[6/6] Cleaning modules...

Ubuntu 24.04

If the system has been previously set up for Python 3.11, then execute the following before running yarn:

unset NODE_GYP_FORCE_PYTHON

Ubuntu 24.10

Python 3.11 is not available for Ubuntu 24.10, so no special preparatory steps are necessary.

Windows 11

In Visual Studio Installer remove any Windows 10 SDK installed. Install Python 3.12 through Microsoft Store.

Confirm that the error "could not find a version of Visual Studio 2017 or newer to use" no longer occurs.

How has the user experience changed?

This issue affects contributors only.

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 force-pushed the issue-30632-update/electron/rebuild branch from a907121 to 588c4f5 Compare November 17, 2024 16:05
@MikeMcC399 MikeMcC399 changed the title update to @electron/[email protected] dependency: update @electron/rebuild to 3.7.1 Nov 17, 2024
@MikeMcC399
Copy link
Contributor Author

An update to CONTRIBUTING > Requirements is needed to remove the workaround instructions which will become obsolete if this PR is merged.

Currently the release/14.0.0 branch lags behind the develop branch, so it's better to wait to avoid update conflicts.

See

git diff release/14.0.0...develop -- CONTRIBUTING.md

@mschile mschile merged commit b8e96a2 into cypress-io:release/14.0.0 Nov 18, 2024
67 of 68 checks passed
@MikeMcC399 MikeMcC399 deleted the issue-30632-update/electron/rebuild branch November 18, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants