breaking: remove log:memory:pressure and firefox:force:gc APIs #30331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
remove-ff-gc
|
| Run status |
|
| Run duration | 17m 14s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
77
|
Skipped
|
0
|
Passing
|
5587
|
| View all changes introduced in this branch ↗︎ | |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
…into remove-ff-gc
…f CDP fails to connect instead of the rtrying socket, which is no longer used when connecting to firefox
mschile
approved these changes
Oct 2, 2024
AtofStryker
reviewed
Oct 2, 2024
| return Cypress.backend('log:memory:pressure') | ||
| }) | ||
| .task('console', { duration }) | ||
| cy.task('stop:capture:memory') |
There was a problem hiding this comment.
do we need this system test anymore? currently the firefox-memory project is only being used in the firefox_spec, and the test looks to be indefinitely skipped https://github.com/cypress-io/cypress/blob/remove-ff-gc/system-tests/test/firefox_spec.ts#L18
There was a problem hiding this comment.
Ah, good catch. Let me look.
There was a problem hiding this comment.
@AtofStryker Removed in 1d3bea0 (#30331)
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log:memory:pressureandfirefox:force:gcfrom the socket API #30222Additional details
Since these two socket methods are no longer needed, it breaks our dependency from needing foxdriver inside the firefox-utils file, further simplifying our firefox automation implementation.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?