Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix firefox default size system test #30759

Merged
merged 1 commit into from
Dec 13, 2024
Merged

test: fix firefox default size system test #30759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions system-tests/projects/screen-size/cypress/e2e/default_size.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ describe('windowSize', () => {
it('spawns with correct default size', () => {
// assert the browser was spawned at 1280x720 and is full size
// normally e2e tests spawn at fixed size, but this spec should be spawned without passing any width/height arguments in plugins file.
// TODO: look into fixing screen/available height and width
if (Cypress.browser.name === 'chrome') {
// NOTE: there is a bug in chrome headless=new where height is not spawned correctly
// the issue is marked as fixed, but others are still running into it in Chrome 116
Expand All @@ -14,14 +13,6 @@ describe('windowSize', () => {
innerWidth: 1280,
innerHeight: 581, // chrome 128 decreased the size here from 633 to 581
})
} else if (Cypress.browser.name === 'firefox') {
expect({
innerWidth: top.window.innerWidth,
innerHeight: top.window.innerHeight,
}).deep.eq({
innerWidth: 1280,
innerHeight: Cypress.env('CI') ? 676 : 677, // firefox 133 decreased the size here from 720 to 676/677
})
} else {
expect({
innerWidth: top.window.innerWidth,
Expand Down
Loading