Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a few MC Gts in autoCond to the latest version available on 14/10/2024 #46379

Merged

Conversation

perrotta
Copy link
Contributor

PR description:

The following GTs are updated in autoCond (in some cases they are not yet the final ones, but they can be tested as such in the IBs).

Backports to CMSSW_14_1_X and CMSSW_14_0_X (limitately to the relevant GTs) wil be provided

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be2eca/42169/summary.html
COMMIT: 0cd9b4f
CMSSW: CMSSW_14_2_X_2024-10-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46379/42169/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 145 lines to the logs
  • Reco comparison results: 17169 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331066
  • DQMHistoTests: Total failures: 96809
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3234237
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.721 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 13034.0 ): 4.721 KiB SiStrip/MechanicalView
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: found differences in 4 / 42 workflows

@mmusich
Copy link
Contributor

mmusich commented Oct 15, 2024

please test for CMSSW_14_2_DBG_X

@perrotta
Copy link
Contributor Author

I would be curious to understand why 2024 MC workflows show differences in tracking (e.g. generalTracks in wf 12834.0) when the only difference between the GTs used for them in reference and PR produced samples is the EcalLaserAPDPNRatios tag, see here the diff wrt the 2024MC GT in autoCond in the reference IB.

If someone has an explanation I would be happy to hear about it. On the other hand, since the GT update is quite simple and clear, I would be tempted to approve this PR nonetheless.

@mmusich
Copy link
Contributor

mmusich commented Oct 15, 2024

If someone has an explanation I would be happy to hear about it.

differences look widespread and compatible with a randomizing effect from regenerated random number sequences in the digitization step. I see that EcalLaserAPDPNRatiosRcd is used in the DIGI step as well in simulation in this twiki - which I think explains why the tag used in the digitization should be compatible with the one used in reconstruction.

@perrotta
Copy link
Contributor Author

If someone has an explanation I would be happy to hear about it.

differences look widespread and compatible with a randomizing effect from regenerated random number sequences in the digitization step. I see that EcalLaserAPDPNRatiosRcd is used in the DIGI step as well in simulation in this twiki - which I think explains why the tag used in the digitization should be compatible with the one used in reconstruction.

It makes sense, indeed. Thank you Marco.

@perrotta
Copy link
Contributor Author

perrotta commented Oct 15, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

-1

Failed Tests: HeaderConsistency UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be2eca/42187/summary.html
COMMIT: 0cd9b4f
CMSSW: CMSSW_14_2_DBG_X_2024-10-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46379/42187/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be2eca/42187/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be2eca/42187/git-merge-result

Unit Tests

I found 4 errors in the following unit tests:

---> test TestDQMOfflineConfigurationGotAll had ERRORS
---> test test_MC_22_crosscheck had ERRORS
---> test test_MC_23_crosscheck had ERRORS
and more ...

Comparison Summary

Summary:

  • You potentially added 9793347 lines to the logs
  • Reco comparison results: 36532 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331066
  • DQMHistoTests: Total failures: 227046
  • DQMHistoTests: Total nulls: 86
  • DQMHistoTests: Total successes: 3103914
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.262 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.070 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 0.469 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.915 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.254 KiB SiStrip/MechanicalView
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: found differences in 9 / 42 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants