Run3-hcx376 Get rid of the obsolete constructor of the HcalTopology class

[bsunanda]

PR description:

Get rid of the obsolete constructor of the HcalTopology class

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46357/42190

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

• Geometry/CaloTopology (geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @fabiocos, @martinamalberti, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[perrotta]

Thank you @bsunanda !
This follows a suggestion proposed by @Dr15Jones in #46308 (comment)

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5f6eb/42133/summary.html
COMMIT: 014af07
CMSSW: CMSSW_14_2_X_2024-10-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46357/42133/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 42 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331066
• DQMHistoTests: Total failures: 3448
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3327598
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[bsunanda]

+geometry

[perrotta]

ping bot

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

urgent
(to be backported in CMSSW_14_1_X together with #46308)

[mandrenguyen]

+1