Run3-hcx373X Correct the HcalTopology class for 2 new geometry modes - backport #46308

[bsunanda]

PR description:

Correct the HcalTopology class for 2 new geometry modes - backport #46308

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #46308

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_14_1_X.

It involves the following packages:

• CondTools/Geometry (db)
• Geometry/CaloTopology (geometry)

@Dr15Jones, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @ReyerBand, @fabiocos, @martinamalberti, @mmusich, @rsreds, @thomreis, @wang0jin, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Run3-hcx373 Correct the HcalTopology class for 2 new geometry modes #46308

[cmsbuild]

cms-bot internal usage

[cmsbuild]

Pull request #46309 was updated. @Dr15Jones, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @perrotta can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9dc4c0/42054/summary.html
COMMIT: b62aca1
CMSSW: CMSSW_14_1_X_2024-10-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46309/42054/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 9033 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331166
• DQMHistoTests: Total failures: 6274
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3324872
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: found differences in 1 / 42 workflows

[cmsbuild]

Pull request #46309 was updated. @Dr15Jones, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @perrotta can you please check and sign again.

[cmsbuild]

Pull request #46309 was updated. @Dr15Jones, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @perrotta can you please check and sign again.

[cmsbuild]

Pull request #46309 was updated. @Dr15Jones, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @perrotta can you please check and sign again.

[cmsbuild]

Pull request #46309 was updated. @Dr15Jones, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @perrotta can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

Pull request #46309 was updated. @Dr15Jones, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @perrotta can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9dc4c0/42139/summary.html
COMMIT: fd51c79
CMSSW: CMSSW_14_1_X_2024-10-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46309/42139/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 17 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331166
• DQMHistoTests: Total failures: 1691
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3329455
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• Verbatim backport of Run3-hcx373 Correct the HcalTopology class for 2 new geometry modes #46308 and Run3-hcx376 Get rid of the obsolete constructor of the HcalTopology class #46357
• The failing unit test has an unrelated das error

[bsunanda]

+geometry

[bsunanda]

@cmsbuild Please test

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9dc4c0/42142/summary.html
COMMIT: fd51c79
CMSSW: CMSSW_14_1_X_2024-10-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46309/42142/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 51 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331166
• DQMHistoTests: Total failures: 3872
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3327274
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

@bsunanda there are some conflicts here now

[bsunanda]

The right version of the HcalTopology class is already there. It is better to close this PR and open a new PR to correct the scripts of calowriter