Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM: restore Muon POG sequence (and CSC Monitor), revert #46293 #46364

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

fabiocos
Copy link
Contributor

PR description:

#46293 has involuntarily removed CSC Monitor DQM output while trying to reduce the memory footprint of DQM harvesting by switching off apparently not crucial muon POG output. This PR simply restores the previous situation to prevent the loss of CSC information, while preparing a better alternative solution

PR validation:

Trivial revert to the previous situation of the affected sequences.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46364/42205

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

  • DQMOffline/Configuration (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@rociovilar, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test

@fabiocos
Copy link
Contributor Author

urgent

@fabiocos
Copy link
Contributor Author

type bugfix

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d67abf/42147/summary.html
COMMIT: a007ae6
CMSSW: CMSSW_14_2_X_2024-10-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46364/42147/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMOfflineConfigurationGotAll had ERRORS

RelVals-INPUT

  • 2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
  • 2024.1010012024.101001_RunZeroBias2024C_10k/step1_dasquery.log
  • 2024.001001DAS Error
Expand to see more relval errors ...
  • 2024.101001

Comparison Summary

Summary:

@fabiocos
Copy link
Contributor Author

The failed unit test fails also in the IB since CMSSW_14_2_X_2024-10-09-2300, the problem appears to be independent on this PR

@iarspider
Copy link
Contributor

@cmsbuild ignore tests-rejected with ib-failure

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants