Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 140X] DQM: restore Muon POG sequence (and CSC Monitor), revert #46298 #46365

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

fabiocos
Copy link
Contributor

PR description:

Effective backport of #46293 to 140X

PR validation:

Simple revert of previous to previously running code.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2024

A new Pull Request was created by @fabiocos for CMSSW_14_0_X.

It involves the following packages:

  • DQMOffline/Configuration (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@rociovilar, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2024

cms-bot internal usage

@fabiocos
Copy link
Contributor Author

please test

@fabiocos
Copy link
Contributor Author

urgent

@fabiocos
Copy link
Contributor Author

big-fix

@fabiocos
Copy link
Contributor Author

bug-fix

@fabiocos
Copy link
Contributor Author

type bugfix

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32adc1/42148/summary.html
COMMIT: 809d78d
CMSSW: CMSSW_14_0_X_2024-10-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46365/42148/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 28 lines to the logs
  • Reco comparison results: 49 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3349412
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3349383
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovagnerini
Copy link

backport of #46293

@antoniovilela
Copy link
Contributor

backport of #46364

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a04b8ba into cms-sw:CMSSW_14_0_X Oct 14, 2024
9 checks passed
@fabiocos fabiocos deleted the fc-140Xrevert46298 branch October 21, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants