[UBSAN][PatCandidates/Tau] Reference binding to null pointer #46409

smuzaffar · 2024-10-16T14:22:54Z

This fixes the UBSAN runtime error [a]. I am opening this PR so that @cms-sw/reconstruction-l2 can review it. It could be that right fix might be to find the reason why

pfSpecific_.push_back(pat::tau::TauPFSpecific(*pfTau));

at https://github.com/cms-sw/cmssw/blob/master/DataFormats/PatCandidates/src/Tau.cc#L125 did not set leadPFChargedHadrCand_ properly?

[a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/raw/el8_amd64_gcc12/CMSSW_14_2_UBSAN_X_2024-10-14-2300/pyRelValMatrixLogs/run/141.004_RunNoBPTX2023B/step3_RunNoBPTX2023B.log

141.004/step3:DataFormats/Common/interface/Ptr.h:223:13: runtime error: reference binding to null pointer of type 'const struct Candidate'

cmsbuild · 2024-10-16T14:23:16Z

cms-bot internal usage

cmsbuild · 2024-10-16T14:24:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46409/42257

cmsbuild · 2024-10-16T14:24:35Z

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

DataFormats/PatCandidates (reconstruction, xpog)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@gouskos, @gpetruc, @hatakeyamak, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2024-10-16T14:25:23Z

test parameters:

workflow = 141.004

smuzaffar · 2024-10-16T14:25:36Z

please test for CMSSW_14_2_UBSAN_X

cmsbuild · 2024-10-16T21:33:31Z

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3269a0/42240/summary.html
COMMIT: dbb0008
CMSSW: CMSSW_14_2_UBSAN_X_2024-10-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46409/42240/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3269a0/42240/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3269a0/42240/git-merge-result

Unit Tests

I found 8 errors in the following unit tests:

---> test test_MC_22_crosscheck had ERRORS
---> test test_MC_23_crosscheck had ERRORS
---> test test_MC_23_setup had ERRORS
and more ...

RelVals

4.53

----- Begin Fatal Exception 16-Oct-2024 21:28:56 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=DeepTauId label='boostedDeepTau20161718v2p0BoostedForMini'
Exception Message:
edm::FileInPath unable to find file RecoTauTag/TrainingFiles/data/BoostedDeepTauId/boosteddeepTau_RunIIv2p0_core.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46409/42240/CMSSW_14_2_UBSAN_X_2024-10-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46409/42240/CMSSW_14_2_UBSAN_X_2024-10-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46409/42240/CMSSW_14_2_UBSAN_X_2024-10-14-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_UBSAN_X_2024-10-14-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_UBSAN_X_2024-10-14-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/4.53_RunPhoton2012B
----- End Fatal Exception -------------------------------------------------

139.001

----- Begin Fatal Exception 16-Oct-2024 21:29:34 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=DeepTauId label='boostedDeepTau20161718v2p0BoostedForMini'
Exception Message:
edm::FileInPath unable to find file RecoTauTag/TrainingFiles/data/BoostedDeepTauId/boosteddeepTau_RunIIv2p0_core.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46409/42240/CMSSW_14_2_UBSAN_X_2024-10-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46409/42240/CMSSW_14_2_UBSAN_X_2024-10-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46409/42240/CMSSW_14_2_UBSAN_X_2024-10-14-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_UBSAN_X_2024-10-14-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_UBSAN_X_2024-10-14-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/139.001_RunMinimumBias2021
----- End Fatal Exception -------------------------------------------------

140.023

----- Begin Fatal Exception 16-Oct-2024 21:30:15 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=DeepTauId label='boostedDeepTau20161718v2p0BoostedForMini'
Exception Message:
edm::FileInPath unable to find file RecoTauTag/TrainingFiles/data/BoostedDeepTauId/boosteddeepTau_RunIIv2p0_core.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46409/42240/CMSSW_14_2_UBSAN_X_2024-10-14-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46409/42240/CMSSW_14_2_UBSAN_X_2024-10-14-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46409/42240/CMSSW_14_2_UBSAN_X_2024-10-14-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_UBSAN_X_2024-10-14-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02859/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_UBSAN_X_2024-10-14-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/140.023_RunZeroBias2022B
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

smuzaffar · 2024-10-17T10:51:38Z

please test

cmsbuild · 2024-10-17T14:51:13Z

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3269a0/42264/summary.html
COMMIT: dbb0008
CMSSW: CMSSW_14_2_X_2024-10-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46409/42264/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

2023.1000012023.100001_RunMuonEG2023D_10k/step1_dasquery.log
2023.1010012023.101001_RunDisplacedJet2023D_10k/step1_dasquery.log
2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log

Expand to see more relval errors ...

2024.001001
2023.100001
2023.101001
2024.000001
2024.001001

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 161 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3426157
DQMHistoTests: Total failures: 929
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3425208
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 197 log files, 167 edm output root files, 45 DQM output files
TriggerResults: no differences found

smuzaffar · 2024-10-18T07:28:19Z

please test

cmsbuild · 2024-10-18T10:56:46Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3269a0/42284/summary.html
COMMIT: dbb0008
CMSSW: CMSSW_14_2_X_2024-10-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46409/42284/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3657359
DQMHistoTests: Total failures: 416
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3656923
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 205 log files, 175 edm output root files, 47 DQM output files
TriggerResults: no differences found

jfernan2 · 2024-10-18T11:06:55Z

+1

hqucms · 2024-10-21T12:51:43Z

+1

cmsbuild · 2024-10-21T12:52:05Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-10-21T15:36:25Z

+1

[UBSAN][PatCandidates/Tau]reference binding to null pointer

dbb0008

cmsbuild added this to the CMSSW_14_2_X milestone Oct 16, 2024

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Oct 16, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 16, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 16, 2024

cmsbuild added tests-rejected and removed tests-started labels Oct 16, 2024

cmsbuild added tests-started and removed tests-rejected labels Oct 17, 2024

cmsbuild added tests-rejected and removed tests-started labels Oct 17, 2024

cmsbuild added tests-started and removed tests-rejected labels Oct 18, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 18, 2024

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 18, 2024

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Oct 21, 2024

cmsbuild added orp-approved and removed orp-pending labels Oct 21, 2024

cmsbuild merged commit ea21598 into cms-sw:master Oct 21, 2024
16 of 18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UBSAN][PatCandidates/Tau] Reference binding to null pointer #46409

[UBSAN][PatCandidates/Tau] Reference binding to null pointer #46409

smuzaffar commented Oct 16, 2024

cmsbuild commented Oct 16, 2024 •

edited

Loading

cmsbuild commented Oct 16, 2024

cmsbuild commented Oct 16, 2024

smuzaffar commented Oct 16, 2024

smuzaffar commented Oct 16, 2024

cmsbuild commented Oct 16, 2024

smuzaffar commented Oct 17, 2024

cmsbuild commented Oct 17, 2024

smuzaffar commented Oct 18, 2024

cmsbuild commented Oct 18, 2024

jfernan2 commented Oct 18, 2024

hqucms commented Oct 21, 2024

cmsbuild commented Oct 21, 2024

mandrenguyen commented Oct 21, 2024

[UBSAN][PatCandidates/Tau] Reference binding to null pointer #46409

[UBSAN][PatCandidates/Tau] Reference binding to null pointer #46409

Conversation

smuzaffar commented Oct 16, 2024

cmsbuild commented Oct 16, 2024 • edited Loading

cmsbuild commented Oct 16, 2024

cmsbuild commented Oct 16, 2024

smuzaffar commented Oct 16, 2024

smuzaffar commented Oct 16, 2024

cmsbuild commented Oct 16, 2024

Unit Tests

RelVals

smuzaffar commented Oct 17, 2024

cmsbuild commented Oct 17, 2024

RelVals-INPUT

Comparison Summary

smuzaffar commented Oct 18, 2024

cmsbuild commented Oct 18, 2024

Comparison Summary

jfernan2 commented Oct 18, 2024

hqucms commented Oct 21, 2024

cmsbuild commented Oct 21, 2024

mandrenguyen commented Oct 21, 2024

cmsbuild commented Oct 16, 2024 •

edited

Loading