Fix DQM config test: Increase number of sequence to test #46334

smuzaffar · 2024-10-10T08:59:29Z

This should fix the failing DQM configuration tests. This PR proposes to adjust the number of DQM sequences

smuzaffar · 2024-10-10T08:59:37Z

please test

cmsbuild · 2024-10-10T08:59:52Z

cms-bot internal usage

cmsbuild · 2024-10-10T09:02:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46334/42166

cmsbuild · 2024-10-10T09:03:09Z

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

DQMOffline/Configuration (dqm)

@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@rociovilar, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-10-10T17:33:46Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab8be8/42089/summary.html
COMMIT: c0bc53f
CMSSW: CMSSW_14_2_X_2024-10-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46334/42089/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

4.53

----- Begin Fatal Exception 10-Oct-2024 17:54:37 CEST-----------------------
An exception of category 'LogicalFileNameNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
Exception Message:
RootFileSequenceBase::initTheFile()
Logical file name '++ echo /store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root' was not found in the file catalog.
If you wanted a local file, you forgot the 'file:' prefix
before the file name in your configuration file.
----- End Fatal Exception -------------------------------------------------

136.731

----- Begin Fatal Exception 10-Oct-2024 17:54:43 CEST-----------------------
An exception of category 'LogicalFileNameNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
Exception Message:
RootFileSequenceBase::initTheFile()
Logical file name '++ echo /store/data/Run2016B/SinglePhoton/RAW/v2/000/274/199/00000/CA646D43-8526-E611-A6D9-02163E014300.root' was not found in the file catalog.
If you wanted a local file, you forgot the 'file:' prefix
before the file name in your configuration file.
----- End Fatal Exception -------------------------------------------------

136.874

----- Begin Fatal Exception 10-Oct-2024 17:54:44 CEST-----------------------
An exception of category 'LogicalFileNameNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
Exception Message:
RootFileSequenceBase::initTheFile()
Logical file name '++ echo /store/data/Run2018C/EGamma/RAW/v1/000/319/450/00000/F49E48A4-E483-E811-8646-02163E019FFC.root' was not found in the file catalog.
If you wanted a local file, you forgot the 'file:' prefix
before the file name in your configuration file.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

cmsbuild · 2024-10-10T21:52:52Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab8be8/42089/summary.html
COMMIT: c0bc53f
CMSSW: CMSSW_14_2_X_2024-10-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46334/42089/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1000.0 step 2
1001.0 step 2
136.731 step 2
136.793 step 2
136.874 step 2
139.001 step 2
140.023 step 2
140.043 step 2
140.063 step 2
140.56 step 2
141.042 step 2
141.044 step 2
141.046 step 2
2500.201 step 2
4.22 step 2
4.53 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially added 11519 lines to the logs
Reco comparison results: 36 differences found in the comparisons
DQMHistoTests: Total files compared: 28
DQMHistoTests: Total histograms compared: 2519569
DQMHistoTests: Total failures: 3439
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2516118
DQMHistoTests: Total skipped: 12
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 27 files compared)
Checked 154 log files, 115 edm output root files, 28 DQM output files
TriggerResults: no differences found

smuzaffar · 2024-10-11T07:08:47Z

please test

smuzaffar · 2024-10-11T07:11:10Z

@cms-sw/dqm-l2 , can you please review this? This is trivial update to increase the number of processed sequences returned by cmsswSequenceInfo.py --runTheMatrix --steps DQM,VALIDATION

cmsbuild · 2024-10-11T10:27:11Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab8be8/42120/summary.html
COMMIT: c0bc53f
CMSSW: CMSSW_14_2_X_2024-10-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46334/42120/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331066
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3331037
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

nothingface0 · 2024-10-14T09:46:38Z

DQMOffline/Configuration/test/BuildFile.xml

@@ -4,12 +4,12 @@
 <test name="GetTestDQMOfflineConfigurationFile" command="edmCopyUtil ${INFILE} $(LOCALTOP)/tmp/"/>

 <!-- To make the tests run in parallel, we chunk up the work into arbitrary sets of 10 sequences. -->
-<test name="TestDQMOfflineConfiguration" command="runtests.sh   ${step_value} ${value} file://${LOCALTOP}/tmp/${INFILE_NAME}" for="0,320,10">
+<test name="TestDQMOfflineConfiguration" command="runtests.sh   ${step_value} ${value} file://${LOCALTOP}/tmp/${INFILE_NAME}" for="0,329,10">


@smuzaffar What is 329? It looks like a magic number in my eyes.

not a magic number. Currently we have 321 sequences returned by cmsswSequenceInfo.py --runTheMatrix --steps DQM,VALIDATION which should be processed by TestDQMOfflineConfiguration_NN unit tests and TestDQMOfflineConfigurationGotAll should not process any sequences (otherwise it should fail).

I could have set this number to 321 but I decided to set it to 329 so that if new extra sequences are added then they can be processed by TestDQMOfflineConfiguration_NN untill we hit 330 sequences

antoniovagnerini · 2024-10-14T09:55:20Z

+1

cmsbuild · 2024-10-14T09:55:41Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-10-15T06:46:52Z

+1

Fix DQM config test: Increase number of sequence to test

c0bc53f

cmsbuild added this to the CMSSW_14_2_X milestone Oct 10, 2024

cmsbuild added dqm-pending pending-signatures orp-pending tests-started code-checks-pending labels Oct 10, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 10, 2024

smuzaffar mentioned this pull request Oct 10, 2024

TestDQMOfflineConfigurationGotAll: increase the number of considered DQM seqs #46336

Closed

cmsbuild added tests-rejected tests-started and removed tests-started tests-rejected labels Oct 10, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 10, 2024

cmsbuild added tests-started and removed tests-approved labels Oct 11, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 11, 2024

nothingface0 reviewed Oct 14, 2024

View reviewed changes

cmsbuild added dqm-approved and removed dqm-pending pending-signatures labels Oct 14, 2024

cmsbuild added the fully-signed label Oct 14, 2024

cmsbuild added orp-approved and removed orp-pending labels Oct 15, 2024

cmsbuild merged commit e755c4a into cms-sw:master Oct 15, 2024
11 checks passed

cmsbuild mentioned this pull request Oct 16, 2024

[UBSAN][PatCandidates/Tau] Reference binding to null pointer #46409

Merged

mmusich mentioned this pull request Oct 17, 2024

[14.1.X] Fix DQM config test: Increase number of sequence to test #46422

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix DQM config test: Increase number of sequence to test #46334

Fix DQM config test: Increase number of sequence to test #46334

smuzaffar commented Oct 10, 2024

smuzaffar commented Oct 10, 2024

cmsbuild commented Oct 10, 2024 •

edited

Loading

cmsbuild commented Oct 10, 2024

cmsbuild commented Oct 10, 2024

cmsbuild commented Oct 10, 2024

cmsbuild commented Oct 10, 2024

smuzaffar commented Oct 11, 2024

smuzaffar commented Oct 11, 2024

cmsbuild commented Oct 11, 2024

nothingface0 Oct 14, 2024

smuzaffar Oct 14, 2024

antoniovagnerini commented Oct 14, 2024

cmsbuild commented Oct 14, 2024

mandrenguyen commented Oct 15, 2024

Fix DQM config test: Increase number of sequence to test #46334

Fix DQM config test: Increase number of sequence to test #46334

Conversation

smuzaffar commented Oct 10, 2024

smuzaffar commented Oct 10, 2024

cmsbuild commented Oct 10, 2024 • edited Loading

cmsbuild commented Oct 10, 2024

cmsbuild commented Oct 10, 2024

cmsbuild commented Oct 10, 2024

RelVals

cmsbuild commented Oct 10, 2024

Comparison Summary

smuzaffar commented Oct 11, 2024

smuzaffar commented Oct 11, 2024

cmsbuild commented Oct 11, 2024

Comparison Summary

nothingface0 Oct 14, 2024

Choose a reason for hiding this comment

smuzaffar Oct 14, 2024

Choose a reason for hiding this comment

antoniovagnerini commented Oct 14, 2024

cmsbuild commented Oct 14, 2024

mandrenguyen commented Oct 15, 2024

cmsbuild commented Oct 10, 2024 •

edited

Loading