Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.1.X] Fix DQM config test: Increase number of sequence to test #46422

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 17, 2024

backport of #46334

PR description:

This should fix the failing DQM configuration tests (report [a]). This PR proposes to adjust the number of DQM sequences
From original PR discussion:

Currently we have 321 sequences returned by cmsswSequenceInfo.py --runTheMatrix --steps DQM,VALIDATION which should be processed by TestDQMOfflineConfiguration_NN unit tests and TestDQMOfflineConfigurationGotAll should not process any sequences (otherwise it should fail).
I could have set this number to 321 but I decided to set it to 329 so that if new extra sequences are added then they can be processed by TestDQMOfflineConfiguration_NN untill we hit 330 sequences

PR validation:

scram b runtests_TestDQMOfflineConfigurationGotAll runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #46334 to CMSSW_14_1_X

[a] https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/el8_amd64_gcc12/www/wed/14.1-wed-23/CMSSW_14_1_X_2024-10-16-2300?utests

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 17, 2024

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • DQMOffline/Configuration (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@rociovilar, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 17, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Oct 17, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4ea4e/42270/summary.html
COMMIT: 86c30ad
CMSSW: CMSSW_14_1_X_2024-10-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46422/42270/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331633
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3331604
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5dbf450 into cms-sw:CMSSW_14_1_X Oct 18, 2024
9 checks passed
@mmusich mmusich deleted the dqm-config-seq329 branch October 18, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants