HLT menu development for 14_0_X (2/N) [14_1_X] #44073

mmusich · 2024-02-24T17:13:02Z

PR description:

Development of HLT menus for CMSSW_14_0_X:

this is an intermediate update towards the 2024 proton-proton run data-taking.

This is the PR for the master branch, which will then be backported down to 14_0_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

This update includes the integration of the following JIRA tickets:

CMSHLT-3050: [SMP] Remove unused L1 seeds from the W3Pi HLT path
CMSHLT-3056: [TSG/EXO] Remove HLT_DiPhoton10smin* paths from the menu
CMSHLT-3063: [BPH/EXO] Remove ParkingDoubleElectronLowMass stream from the GRun menu
CMSHLT-3064: [TAU] Remove deprecated L1T seeds from hltL1sTauVeryBigOR
CMSHLT-3024: [BTV/SUS] MSSM Hbb triggers migration from DeepJet to PNet
CMSHLT-3068: [Scouting] Removal of the EG30 Scouting path
CMSHLT-3055: [PPS/ALCA] Configuration in HLT menu for new O2O/LHCInfoPer*
CMSHLT-3028: [B2G/HIG] Replacement of MassSD paths with SoftDropMass
CMSHLT-3033: [SUS] Update of HLT_DoubleMu3_DCA_PFMET50_PFMHT60 and new auxiliary paths
CMSHLT-3029: [TAU] Adding DoubleTau+Jet paths including PNet
CMSHLT-3046: [TSG] Cleanup of MC Paths in GRun
CMSHLT-3037: [HIG/TAU/SMP] ParticleNet Versions of ETau, MuTau, and ETau Monitoring HLTs
CMSHLT-3031: [EXO] Integration of MDS+X triggers
CMSHLT-3077: [HIG/TAU] Fix IsoMu+PNet control triggers ('ignore' filters)
CMSHLT-3034: [EGM/JME/EXO/HIG] 50 GeV unprescaled single photon path
CMSHLT-3030: [PPS/SMP] Add PPS-Jet trigger to the 2024 menu
CMSHLT-3058: [HIG/EXO] VBF parking triggers for 2024
CMSHLT-3052: [HIG/TAU] VBF PNet HLT Integration
CMSHLT-3035: [L1T] HLT menu updates for L1Menu_Collisions2024_v1_0_0

In addition:

commit c708774 : update of L1T FULL, GRun, PIon, PRef, Special menus in TSG GTs to L1Menu_Collisions2024_v1_0_0_xml
commit 5c3431c : percolates the CMSHLT-3027 (already integrated in HLT menu development for 14_0_X (1/N) [14_1_X] #44023) changes to the @Fake2 menu

PR validation:

TSG integration tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported to CMSSW_14_0_X.

Important Note

N.B. Note to @cms-sw/orp-l2 this PR MUST be merged together with #44078, that PR updates the L1TUtmTriggerMenu record to use L1Menu_Collisions2024_v1_0_0_xml in the Configuration/AlCa package: (see more details at this cmsTalk post). Updates:

2024 simulation autoCond keys
symbolic run3_data_relval and run3_hlt_relval keys

This is an intermediate update towards the 2024 proton-proton run data-taking. This update includes the integration of the following JIRA tickets: - [CMSHLT-3050](https://its.cern.ch/jira/browse/CMSHLT-3050): [SMP] Remove unused L1 seeds from the W3Pi HLT path - [CMSHLT-3056](https://its.cern.ch/jira/browse/CMSHLT-3056): [TSG/EXO] Remove HLT_DiPhoton10smin* paths from the menu - [CMSHLT-3063](https://its.cern.ch/jira/browse/CMSHLT-3063): [BPH/EXO] Remove ParkingDoubleElectronLowMass stream from the GRun menu - [CMSHLT-3064](https://its.cern.ch/jira/browse/CMSHLT-3064): [TAU] Remove deprecated L1T seeds from hltL1sTauVeryBigOR - [CMSHLT-3024](https://its.cern.ch/jira/browse/CMSHLT-3024): [BTV/SUS] MSSM Hbb triggers migration from DeepJet to PNet - [CMSHLT-3068](https://its.cern.ch/jira/browse/CMSHLT-3068): [Scouting] Removal of the EG30 Scouting path - [CMSHLT-3055](https://its.cern.ch/jira/browse/CMSHLT-3055): [PPS/ALCA] Configuration in HLT menu for new O2O/LHCInfoPer* - [CMSHLT-3028](https://its.cern.ch/jira/browse/CMSHLT-3028): [B2G/HIG] Replacement of MassSD paths with SoftDropMass - [CMSHLT-3033](https://its.cern.ch/jira/browse/CMSHLT-3033): [SUS] Update of HLT_DoubleMu3_DCA_PFMET50_PFMHT60 and new auxiliary paths - [CMSHLT-3029](https://its.cern.ch/jira/browse/CMSHLT-3029): [TAU] Adding DoubleTau+Jet paths including PNet - [CMSHLT-3046](https://its.cern.ch/jira/browse/CMSHLT-3046): [TSG] Cleanup of MC Paths in GRun - [CMSHLT-3037](https://its.cern.ch/jira/browse/CMSHLT-3037): [HIG/TAU/SMP] ParticleNet Versions of ETau, MuTau, and ETau Monitoring HLTs - [CMSHLT-3031](https://its.cern.ch/jira/browse/CMSHLT-3031): [EXO] Integration of MDS+X triggers - [CMSHLT-3077](https://its.cern.ch/jira/browse/CMSHLT-3077): [HIG/TAU] Fix IsoMu+PNet control triggers ('ignore' filters) - [CMSHLT-3034](https://its.cern.ch/jira/browse/CMSHLT-3034): [EGM/JME/EXO/HIG] 50 GeV unprescaled single photon path - [CMSHLT-3030](https://its.cern.ch/jira/browse/CMSHLT-3030): [PPS/SMP] Add PPS-Jet trigger to the 2024 menu - [CMSHLT-3058](https://its.cern.ch/jira/browse/CMSHLT-3058): [HIG/EXO] VBF parking triggers for 2024 - [CMSHLT-3052](https://its.cern.ch/jira/browse/CMSHLT-3052): [HIG/TAU] VBF PNet HLT Integration

cmsbuild · 2024-02-24T17:13:29Z

cms-bot internal usage

Configuration/AlCa/python/autoCond.py

cmsbuild · 2024-02-24T17:17:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44073/39034

This PR adds an extra 900KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/AlCa/python/autoCond.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLT_FULL_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLT_Fake2_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLT_GRun_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLT_HIon_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLT_PIon_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLT_PRef_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLT_Special_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLTrigger_Datasets_GRun_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/tables/GRun.txt modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/tables/online_grun.txt modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_FULL.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_Fake2.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_GRun.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_HIon.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_PIon.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_PRef.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_Special.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976

cmsbuild · 2024-02-24T17:18:06Z

A new Pull Request was created by @mmusich for master.

It involves the following packages:

Configuration/AlCa (alca)
Configuration/HLT (hlt)
HLTrigger/Configuration (hlt)

@consuegs, @mmusich, @perrotta, @saumyaphor4252, @cmsbuild, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@mmusich, @missirol, @silviodonato, @tocheng, @rsreds, @Martin-Grunewald, @fabiocos, @yuanchao this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

mmusich · 2024-02-24T17:53:43Z

@cmsbuild, please test

cmsbuild · 2024-02-24T21:33:40Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d3d0/37657/summary.html
COMMIT: 8195bb8
CMSSW: CMSSW_14_1_X_2024-02-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44073/37657/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 109 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 40 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3239687
DQMHistoTests: Total failures: 363
DQMHistoTests: Total nulls: 56
DQMHistoTests: Total successes: 3239246
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -9839.385 KiB( 47 files compared)
DQMHistoSizes: changed ( 141.042,... ): -1496.730 KiB HLT/HIG
DQMHistoSizes: changed ( 141.042,... ): -1369.777 KiB HLT/B2G
DQMHistoSizes: changed ( 141.042,... ): -289.945 KiB HLT/JME
DQMHistoSizes: changed ( 141.042,... ): -72.971 KiB HLT/EGM
DQMHistoSizes: changed ( 141.042,... ): -54.307 KiB HLT/EXO
DQMHistoSizes: changed ( 141.042,... ): 4.240 KiB HLT/Filters
DQMHistoSizes: changed ( 141.042,... ): -0.305 KiB HLT/TAU
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: found differences in 2 / 46 workflows

perrotta · 2024-02-25T09:05:09Z

@mmusich the PR with the updated versioned GTs in autoCond is in #44078
Please remove the corresponding files from this PR and retest the two PRs together afterwards

mmusich · 2024-02-25T10:03:51Z

Please remove the corresponding files from this PR and retest the two PRs together afterwards

No need of two PRs, that risks only to create broken IBs if not merged together.

perrotta · 2024-02-25T11:21:10Z

Please remove the corresponding files from this PR and retest the two PRs together afterwards

No need of two PRs, that risks only to create broken IBs if not merged together.

If you don't mind I'd keep them separate, for AlCa boockeeping purpose, and insist with the release managers for having them merged together.
If you really prefere, you can remove the updates to autoCond here (they must be fixed anyhow) and import the very same commit that is in the other PR, so that once this is merged tge other will follow automatically.

…Collisions2024_v1_0_0_xml

mmusich · 2024-02-25T11:58:25Z

test parameters:

pull_request = Update 2024 MC GTs with the L1 menu #44078

mmusich · 2024-02-25T11:58:38Z

If you don't mind I'd keep them separate, for AlCa boockeeping purpose, and insist with the release managers for having them merged together.

OK, let's hope for the best...

cmsbuild · 2024-02-25T12:05:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44073/39042

This PR adds an extra 900KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/HLT_FULL_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLT_Fake2_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLT_GRun_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLT_HIon_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLT_PIon_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLT_PRef_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLT_Special_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/python/HLTrigger_Datasets_GRun_cff.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/tables/GRun.txt modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/tables/online_grun.txt modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_FULL.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_Fake2.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_GRun.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_HIon.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_PIon.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_PRef.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976
- File HLTrigger/Configuration/test/OnLine_HLT_Special.py modified in PR(s): Fix on muon_mvaID in NanoAOD #43976

cmsbuild · 2024-02-25T12:06:01Z

Pull request #44073 was updated. @cmsbuild, @Martin-Grunewald, @mmusich can you please check and sign again.

mmusich · 2024-02-25T12:06:13Z

@cmsbuild, please test

cmsbuild · 2024-02-25T14:53:22Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d3d0/37668/summary.html
COMMIT: 5c3431c
CMSSW: CMSSW_14_1_X_2024-02-25-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44073/37668/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 101 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 66 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3239687
DQMHistoTests: Total failures: 1558
DQMHistoTests: Total nulls: 56
DQMHistoTests: Total successes: 3238051
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -9839.385 KiB( 47 files compared)
DQMHistoSizes: changed ( 141.042,... ): -1496.730 KiB HLT/HIG
DQMHistoSizes: changed ( 141.042,... ): -1369.777 KiB HLT/B2G
DQMHistoSizes: changed ( 141.042,... ): -289.945 KiB HLT/JME
DQMHistoSizes: changed ( 141.042,... ): -72.971 KiB HLT/EGM
DQMHistoSizes: changed ( 141.042,... ): -54.307 KiB HLT/EXO
DQMHistoSizes: changed ( 141.042,... ): 4.240 KiB HLT/Filters
DQMHistoSizes: changed ( 141.042,... ): -0.305 KiB HLT/TAU
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: found differences in 2 / 46 workflows

mmusich · 2024-02-25T16:04:59Z

+hlt

test pass and reveal expected changes;
additional empty DQM plots or additional log lines are due to the fact that some DQM plugins create or remove plots based on the content of the menu because they select Paths based on regular expressions or similar. Other times, the name of the Paths are hardcoded in the DQM sequences, and POGs/PAGs need to update them themselves. TSG will follow-up with proponents after integration.

cmsbuild · 2024-02-25T16:05:23Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44078

cmsbuild · 2024-02-25T21:08:21Z

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with #44078, please check if they should be merged together

rappoccio · 2024-02-26T20:18:36Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone Feb 24, 2024

cmsbuild added hlt-pending alca-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 24, 2024

mmusich mentioned this pull request Feb 24, 2024

HLT menu development for 14_0_X (2/N) #44074

Merged

mmusich commented Feb 24, 2024

View reviewed changes

Configuration/AlCa/python/autoCond.py Outdated Show resolved Hide resolved

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 24, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 24, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 24, 2024

perrotta mentioned this pull request Feb 25, 2024

Update 2024 MC GTs with the L1 menu #44078

Merged

mmusich added 2 commits February 25, 2024 12:53

update of L1T FULL,GRun,PIon,PRef,Special menus in TSG GTs to L1Menu_…

c708774

…Collisions2024_v1_0_0_xml

percolate the CMSHLT-3027 changes to the Fake2 menu

5c3431c

mmusich force-pushed the HLTdevelopment140X_for141X branch from 8195bb8 to 5c3431c Compare February 25, 2024 11:55

cmsbuild removed alca-pending tests-approved labels Feb 25, 2024

cmsbuild added the code-checks-pending label Feb 25, 2024

cmsbuild added the requires-external label Feb 25, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 25, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 25, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 25, 2024

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Feb 25, 2024

cmsbuild added orp-approved and removed orp-pending labels Feb 26, 2024

cmsbuild merged commit 1342ab1 into cms-sw:master Feb 26, 2024
12 checks passed

mmusich deleted the HLTdevelopment140X_for141X branch February 26, 2024 20:44

mmusich mentioned this pull request Feb 27, 2024

[14.0.X] Update 2024 MC GTs with the L1 menu #44080

Merged

This was referenced Mar 12, 2024

DeepTauId failures in RelVals (Incompatible shapes) #44333

Closed

Get AXOL1TL model version from menu as of utm v0.12.0 #44054

Merged

mmusich mentioned this pull request May 31, 2024

[14_0_X] Add possibility to read triggerbits for Secondary Datasets from the GT #45115

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HLT menu development for 14_0_X (2/N) [14_1_X] #44073

HLT menu development for 14_0_X (2/N) [14_1_X] #44073

mmusich commented Feb 24, 2024 •

edited

Loading

cmsbuild commented Feb 24, 2024 •

edited

Loading

cmsbuild commented Feb 24, 2024

cmsbuild commented Feb 24, 2024

mmusich commented Feb 24, 2024

cmsbuild commented Feb 24, 2024

perrotta commented Feb 25, 2024

mmusich commented Feb 25, 2024

perrotta commented Feb 25, 2024

mmusich commented Feb 25, 2024

mmusich commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

mmusich commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

mmusich commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

rappoccio commented Feb 26, 2024

HLT menu development for 14_0_X (2/N) [14_1_X] #44073

HLT menu development for 14_0_X (2/N) [14_1_X] #44073

Conversation

mmusich commented Feb 24, 2024 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Important Note

cmsbuild commented Feb 24, 2024 • edited Loading

cmsbuild commented Feb 24, 2024

cmsbuild commented Feb 24, 2024

mmusich commented Feb 24, 2024

cmsbuild commented Feb 24, 2024

Comparison Summary

perrotta commented Feb 25, 2024

mmusich commented Feb 25, 2024

perrotta commented Feb 25, 2024

mmusich commented Feb 25, 2024

mmusich commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

mmusich commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

Comparison Summary

mmusich commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

cmsbuild commented Feb 25, 2024

rappoccio commented Feb 26, 2024

mmusich commented Feb 24, 2024 •

edited

Loading

cmsbuild commented Feb 24, 2024 •

edited

Loading