Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 14_0_X (2/N) #44074

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 24, 2024

backport of #44073

PR description:

Development of HLT menus for CMSSW_14_0_X:

  • this is an intermediate update towards the 2024 proton-proton run data-taking.

This is the 14_0_X branch, this is the release cycle currently used for Run-3 HLT-menu development).

This update includes the integration of the following JIRA tickets:

  • CMSHLT-3050: [SMP] Remove unused L1 seeds from the W3Pi HLT path
  • CMSHLT-3056: [TSG/EXO] Remove HLT_DiPhoton10smin* paths from the menu
  • CMSHLT-3063: [BPH/EXO] Remove ParkingDoubleElectronLowMass stream from the GRun menu
  • CMSHLT-3064: [TAU] Remove deprecated L1T seeds from hltL1sTauVeryBigOR
  • CMSHLT-3024: [BTV/SUS] MSSM Hbb triggers migration from DeepJet to PNet
  • CMSHLT-3068: [Scouting] Removal of the EG30 Scouting path
  • CMSHLT-3055: [PPS/ALCA] Configuration in HLT menu for new O2O/LHCInfoPer*
  • CMSHLT-3028: [B2G/HIG] Replacement of MassSD paths with SoftDropMass
  • CMSHLT-3033: [SUS] Update of HLT_DoubleMu3_DCA_PFMET50_PFMHT60 and new auxiliary paths
  • CMSHLT-3029: [TAU] Adding DoubleTau+Jet paths including PNet
  • CMSHLT-3046: [TSG] Cleanup of MC Paths in GRun
  • CMSHLT-3037: [HIG/TAU/SMP] ParticleNet Versions of ETau, MuTau, and ETau Monitoring HLTs
  • CMSHLT-3031: [EXO] Integration of MDS+X triggers
  • CMSHLT-3077: [HIG/TAU] Fix IsoMu+PNet control triggers ('ignore' filters)
  • CMSHLT-3034: [EGM/JME/EXO/HIG] 50 GeV unprescaled single photon path
  • CMSHLT-3030: [PPS/SMP] Add PPS-Jet trigger to the 2024 menu
  • CMSHLT-3058: [HIG/EXO] VBF parking triggers for 2024
  • CMSHLT-3052: [HIG/TAU] VBF PNet HLT Integration
  • CMSHLT-3035: [L1T] HLT menu updates for L1Menu_Collisions2024_v1_0_0

In addition:

PR validation:

TSG integration tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #44073 to CMSSW_14_0_X for HLT menu development.


Important Note

N.B. Note to @cms-sw/orp-l2 this PR MUST be merged together with #44080, that PR updates the L1TUtmTriggerMenu record to use L1Menu_Collisions2024_v1_0_0_xml in the Configuration/AlCa package: (see more details at this cmsTalk post). Updates:

  • 2024 simulation autoCond keys
  • symbolic run3_data_relval and run3_hlt_relval keys

This is an intermediate update towards the 2024 proton-proton run data-taking.
This update includes the integration of the following JIRA tickets:
- [CMSHLT-3050](https://its.cern.ch/jira/browse/CMSHLT-3050): [SMP] Remove unused L1 seeds from the W3Pi HLT path
- [CMSHLT-3056](https://its.cern.ch/jira/browse/CMSHLT-3056): [TSG/EXO] Remove HLT_DiPhoton10smin* paths from the menu
- [CMSHLT-3063](https://its.cern.ch/jira/browse/CMSHLT-3063): [BPH/EXO] Remove ParkingDoubleElectronLowMass stream from the GRun menu
- [CMSHLT-3064](https://its.cern.ch/jira/browse/CMSHLT-3064): [TAU] Remove deprecated L1T seeds from hltL1sTauVeryBigOR
- [CMSHLT-3024](https://its.cern.ch/jira/browse/CMSHLT-3024): [BTV/SUS] MSSM Hbb triggers migration from DeepJet to PNet
- [CMSHLT-3068](https://its.cern.ch/jira/browse/CMSHLT-3068): [Scouting] Removal of the EG30 Scouting path
- [CMSHLT-3055](https://its.cern.ch/jira/browse/CMSHLT-3055): [PPS/ALCA] Configuration in HLT menu for new O2O/LHCInfoPer*
- [CMSHLT-3028](https://its.cern.ch/jira/browse/CMSHLT-3028): [B2G/HIG] Replacement of MassSD paths with SoftDropMass
- [CMSHLT-3033](https://its.cern.ch/jira/browse/CMSHLT-3033): [SUS] Update of HLT_DoubleMu3_DCA_PFMET50_PFMHT60 and new auxiliary paths
- [CMSHLT-3029](https://its.cern.ch/jira/browse/CMSHLT-3029): [TAU] Adding DoubleTau+Jet paths including PNet
- [CMSHLT-3046](https://its.cern.ch/jira/browse/CMSHLT-3046): [TSG] Cleanup of MC Paths in GRun
- [CMSHLT-3037](https://its.cern.ch/jira/browse/CMSHLT-3037): [HIG/TAU/SMP] ParticleNet Versions of ETau, MuTau, and ETau Monitoring HLTs
- [CMSHLT-3031](https://its.cern.ch/jira/browse/CMSHLT-3031): [EXO] Integration of MDS+X triggers
- [CMSHLT-3077](https://its.cern.ch/jira/browse/CMSHLT-3077): [HIG/TAU] Fix IsoMu+PNet control triggers ('ignore' filters)
- [CMSHLT-3034](https://its.cern.ch/jira/browse/CMSHLT-3034): [EGM/JME/EXO/HIG] 50 GeV unprescaled single photon path
- [CMSHLT-3030](https://its.cern.ch/jira/browse/CMSHLT-3030): [PPS/SMP] Add PPS-Jet trigger to the 2024 menu
- [CMSHLT-3058](https://its.cern.ch/jira/browse/CMSHLT-3058): [HIG/EXO] VBF parking triggers for 2024
- [CMSHLT-3052](https://its.cern.ch/jira/browse/CMSHLT-3052): [HIG/TAU] VBF PNet HLT Integration
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@consuegs, @saumyaphor4252, @Martin-Grunewald, @perrotta, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@fabiocos, @yuanchao, @rsreds, @Martin-Grunewald, @tocheng, @missirol, @silviodonato, @mmusich this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 24, 2024

testing of this PR requires at least #44045, so won't test for now.

@cmsbuild
Copy link
Contributor

Pull request #44074 was updated. @cmsbuild, @Martin-Grunewald, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 25, 2024

test parameters:

@mmusich
Copy link
Contributor Author

mmusich commented Feb 25, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3fb4d6/37672/summary.html
COMMIT: fe59acf
CMSSW: CMSSW_14_0_X_2024-02-25-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44074/37672/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 76 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 53 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3239723
  • DQMHistoTests: Total failures: 1786
  • DQMHistoTests: Total nulls: 59
  • DQMHistoTests: Total successes: 3237856
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -9839.385 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 141.042,... ): -1496.730 KiB HLT/HIG
  • DQMHistoSizes: changed ( 141.042,... ): -1369.777 KiB HLT/B2G
  • DQMHistoSizes: changed ( 141.042,... ): -289.945 KiB HLT/JME
  • DQMHistoSizes: changed ( 141.042,... ): -72.971 KiB HLT/EGM
  • DQMHistoSizes: changed ( 141.042,... ): -54.307 KiB HLT/EXO
  • DQMHistoSizes: changed ( 141.042,... ): 4.240 KiB HLT/Filters
  • DQMHistoSizes: changed ( 141.042,... ): -0.305 KiB HLT/TAU
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 3 / 46 workflows

@mmusich
Copy link
Contributor Author

mmusich commented Feb 25, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44080

@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

urgent

@cmsbuild
Copy link
Contributor

REMINDER @antoniovilela, @sextonkennedy, @rappoccio: This PR was tested with #44080, please check if they should be merged together

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c7f69db into cms-sw:CMSSW_14_0_X Feb 28, 2024
11 checks passed
@mmusich mmusich deleted the HLTdevelopment140X branch February 28, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants