Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Update 2024 MC GTs with the L1 menu #44080

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 25, 2024

backport of #44078

PR description:

Update the 2024 MC GTs with the new L1 menu as in cmsTalk https://cms-talk.web.cern.ch/t/update-of-the-2024-l1-menu-tag-l1menu-collisions2024-v1-1-0/35509

The updated tag for L1TUtmTriggerMenuRcd is
From: L1Menu_Collisions2023_v1_2_0_xml
To: L1Menu_Collisions2024_v1_0_0_xml

GT differences:

PR validation:

This must be tested (and merged) together with #44074.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #44078

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@saumyaphor4252, @cmsbuild, @perrotta, @consuegs can you please review it and eventually sign? Thanks.
@rsreds, @mmusich, @missirol, @Martin-Grunewald, @tocheng, @yuanchao, @fabiocos this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 25, 2024

test parameters:

@mmusich
Copy link
Contributor Author

mmusich commented Feb 25, 2024

@cmsbuild, please test

@perrotta
Copy link
Contributor

Thank you @mmusich for having anticipated it (I was going to do the same, but being leaving to take the train to Geneve it would have taken a bit more time)

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with #44074, please check if they should be merged together

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ce1e1/37673/summary.html
COMMIT: a701f86
CMSSW: CMSSW_14_0_X_2024-02-25-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44080/37673/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 54 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 53 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3239723
  • DQMHistoTests: Total failures: 1786
  • DQMHistoTests: Total nulls: 59
  • DQMHistoTests: Total successes: 3237856
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -9839.385 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 141.042,... ): -1496.730 KiB HLT/HIG
  • DQMHistoSizes: changed ( 141.042,... ): -1369.777 KiB HLT/B2G
  • DQMHistoSizes: changed ( 141.042,... ): -289.945 KiB HLT/JME
  • DQMHistoSizes: changed ( 141.042,... ): -72.971 KiB HLT/EGM
  • DQMHistoSizes: changed ( 141.042,... ): -54.307 KiB HLT/EXO
  • DQMHistoSizes: changed ( 141.042,... ): 4.240 KiB HLT/Filters
  • DQMHistoSizes: changed ( 141.042,... ): -0.305 KiB HLT/TAU
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 3 / 46 workflows

@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

@cms-sw/alca-l2 please sign this PR. The combination of #44078 + #44073 has successfully run in the last IB

@mmusich
Copy link
Contributor Author

mmusich commented Feb 27, 2024

urgent

@saumyaphor4252
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44074

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f3d7082 into cms-sw:CMSSW_14_0_X Feb 28, 2024
11 checks passed
@mmusich mmusich deleted the from_perrottau_pdate2024MCGTwithL1Menu_14_0_X branch March 1, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants