Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2024 MC GTs with the L1 menu #44078

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

perrotta
Copy link
Contributor

PR description:

Update the 2024 MC GTs with the new L1 menu as in cmsTalk https://cms-talk.web.cern.ch/t/update-of-the-2024-l1-menu-tag-l1menu-collisions2024-v1-1-0/35509

The updated tag for L1TUtmTriggerMenuRcd is
From: L1Menu_Collisions2023_v1_2_0_xml
To: L1Menu_Collisions2024_v1_0_0_xml

GT differences

PR validation:

This must be tested (and merged) together with #44073 once the corresponding GT updates are removed from that PR so that the ones here are picked instead

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported

This will have to be backported in 14_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor Author

test parameters:

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44078/39039

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @consuegs, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks.
@fabiocos, @rsreds, @tocheng, @yuanchao, @Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Feb 25, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Feb 25, 2024

@perrotta, please provide a backport to CMSSW_14.0.X such that it can be tested with #44074

@mmusich
Copy link
Contributor

mmusich commented Feb 25, 2024

lease provide a backport to CMSSW_14.0.X such that it can be tested with #44074

to speed-up integration I took the liberty to do it myself: #44080

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd7db9/37667/summary.html
COMMIT: 2242ac6
CMSSW: CMSSW_14_1_X_2024-02-25-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44078/37667/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 85 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 42 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3239687
  • DQMHistoTests: Total failures: 366
  • DQMHistoTests: Total nulls: 56
  • DQMHistoTests: Total successes: 3239243
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -9839.385 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 141.042,... ): -1496.730 KiB HLT/HIG
  • DQMHistoSizes: changed ( 141.042,... ): -1369.777 KiB HLT/B2G
  • DQMHistoSizes: changed ( 141.042,... ): -289.945 KiB HLT/JME
  • DQMHistoSizes: changed ( 141.042,... ): -72.971 KiB HLT/EGM
  • DQMHistoSizes: changed ( 141.042,... ): -54.307 KiB HLT/EXO
  • DQMHistoSizes: changed ( 141.042,... ): 4.240 KiB HLT/Filters
  • DQMHistoSizes: changed ( 141.042,... ): -0.305 KiB HLT/TAU
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with #44073, please check if they should be merged together

@perrotta
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44073

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5cc282c into cms-sw:master Feb 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants