Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 14_0_X (1/N) [14_1_X] #44023

Merged
merged 13 commits into from
Feb 21, 2024

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

HLT menu development for 14_0_X (1/N) [14_1_X]

Also includes migration to ConfDb template CMSSW_14_0_0

The following CMSHLT Jira tickets are included:

https://its.cern.ch/jira/browse/CMSHLT-3048: [TSG/HIon] Removal of EventContent/Stream/PD related to HIHLTMonitor
https://its.cern.ch/jira/browse/CMSHLT-3035: [BPH] HLT_ZeroBias prescale for physics menu
https://its.cern.ch/jira/browse/CMSHLT-3027: [L1T] Set hltGtStage2ObjectMap AXOL1TLModelVersion ="GTADModel_v3" ….
https://its.cern.ch/jira/browse/CMSHLT-3025: [Scouting] Extending the Jet Eta cut
https://its.cern.ch/jira/browse/CMSHLT-3023: [B2G] Request of tagger migration in FivePFJet+2b-tag path
https://its.cern.ch/jira/browse/CMSHLT-3022: [HIG] Update L1 seeds for VBFHToCC HLT path
https://its.cern.ch/jira/browse/CMSHLT-3020: [SUS] Removal of VBF + X paths and replacing with VBF-exclusive paths
https://its.cern.ch/jira/browse/CMSHLT-2989: [PPS] Add new module in ALCAPPSPrompt
https://its.cern.ch/jira/browse/CMSHLT-2983: [TSG] Removal of hltParticleFlowClusterHFForEgammaUnseeded
https://its.cern.ch/jira/browse/CMSHLT-2981: [TSG] Removal of deprecated GRun Paths (post Run2023)
https://its.cern.ch/jira/browse/CMSHLT-2980: [TSG] Remove unused Paths from HLT combined menu (post Run2023)

PR validation:

TSG tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_0 (data taking release)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2024

cms-bot internal usage

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44023/38953

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald for master.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@silviodonato, @fabiocos, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36b640/37570/summary.html
COMMIT: ff3f1ba
CMSSW: CMSSW_14_1_X_2024-02-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44023/37570/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 60 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3245310
  • DQMHistoTests: Total failures: 2228
  • DQMHistoTests: Total nulls: 63
  • DQMHistoTests: Total successes: 3242997
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3782.2980000000002 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 141.042,... ): -738.156 KiB HLT/TOP
  • DQMHistoSizes: changed ( 141.042,... ): -308.779 KiB HLT/SUSY
  • DQMHistoSizes: changed ( 141.042,... ): -145.439 KiB HLT/JME
  • DQMHistoSizes: changed ( 141.042,... ): -60.436 KiB HLT/Filters
  • DQMHistoSizes: changed ( 141.042,... ): -7.955 KiB HLT/TAU
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 3 / 46 workflows

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c0411ef into cms-sw:master Feb 21, 2024
11 checks passed
@mmusich mmusich deleted the HLTdevelopment140X_for141X branch February 22, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants