-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the ratio timing method for ECAL online DQM #42932
Use the ratio timing method for ECAL online DQM #42932
Conversation
type ecal |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42932/37079
|
A new Pull Request was created by @thomreis (Thomas Reis) for master. It involves the following packages:
@nothingface0, @antoniovagnerini, @rvenditti, @tjavaid, @syuvivida, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a6a8b/35023/summary.html Comparison SummarySummary:
|
5905371
to
ce767b7
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42932/37111
|
Pull request #42932 was updated. @antoniovagnerini, @syuvivida, @tjavaid, @cmsbuild, @rvenditti, @nothingface0 can you please check and sign again. |
Updated this PR to explicitly set the record labels for the time calibration and time offset conditions. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a6a8b/35070/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR sets the ECAL timing algorithm used in the online DQM reconstruction to the ratio method. Like this the online DQM monitors the algorithm that is used at the HLT and can also directly use the calibrations and offsets from the HLT GT.
PR validation:
Ran ecal_dqm_sourceclient-live_cfg.py configuration locally.