Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the ratio timing method for ECAL online DQM #42932

Merged

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Oct 3, 2023

PR description:

This PR sets the ECAL timing algorithm used in the online DQM reconstruction to the ratio method. Like this the online DQM monitors the algorithm that is used at the HLT and can also directly use the calibrations and offsets from the HLT GT.

PR validation:

Ran ecal_dqm_sourceclient-live_cfg.py configuration locally.

@thomreis
Copy link
Contributor Author

thomreis commented Oct 3, 2023

type ecal

@cmsbuild cmsbuild added the ecal label Oct 3, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42932/37079

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2023

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

  • DQM/Integration (dqm)

@nothingface0, @antoniovagnerini, @rvenditti, @tjavaid, @syuvivida, @cmsbuild can you please review it and eventually sign? Thanks.
@wang0jin, @rchatter, @batinkov, @thomreis, @francescobrivio, @threus, @argiro this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

thomreis commented Oct 3, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a6a8b/35023/summary.html
COMMIT: 5905371
CMSSW: CMSSW_13_3_X_2023-10-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42932/35023/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358320
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358295
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42932/37111

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

Pull request #42932 was updated. @antoniovagnerini, @syuvivida, @tjavaid, @cmsbuild, @rvenditti, @nothingface0 can you please check and sign again.

@thomreis
Copy link
Contributor Author

thomreis commented Oct 5, 2023

Updated this PR to explicitly set the record labels for the time calibration and time offset conditions.

@thomreis
Copy link
Contributor Author

thomreis commented Oct 5, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a6a8b/35070/summary.html
COMMIT: ce767b7
CMSSW: CMSSW_13_3_X_2023-10-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42932/35070/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356895
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Oct 7, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants