Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the ratio timing method for ECAL online DQM- 132X part 2 #43024

Conversation

thomreis
Copy link
Contributor

PR description:

This PR extends the backport PR #42933 and explicitly sets the time algorithm conditions tag such that is also works together with PR #42946 .

Together with PR #42933 this matches the behaviour of the master PR #42932.

PR validation:

Ran ecal_dqm_sourceclient-live_cfg.py configuration locally.

Backport of #42932

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2023

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_13_2_X.

It involves the following packages:

  • DQM/Integration (dqm)

@rvenditti, @nothingface0, @cmsbuild, @tjavaid, @syuvivida, @antoniovagnerini can you please review it and eventually sign? Thanks.
@wang0jin, @thomreis, @argiro, @threus, @batinkov, @rchatter, @francescobrivio this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

type ecal

@thomreis
Copy link
Contributor Author

backport of #42932

@thomreis
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35ed7b/35205/summary.html
COMMIT: 223bb21
CMSSW: CMSSW_13_2_X_2023-10-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43024/35205/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198659
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198631
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Oct 16, 2023

+1

  • P5 tests okay with CMSSW_13_2_6_patch1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

Does this need, or only makes sense, with #42946?

@thomreis
Copy link
Contributor Author

This should not need #42946 but the other way around. This PR ensures that for online DQM the timing algorithm and its conditions always match.

@antoniovilela
Copy link
Contributor

This should not need #42946 but the other way around. This PR ensures that for online DQM the timing algorithm and its conditions always match.

Ok, thanks.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a8046d7 into cms-sw:CMSSW_13_2_X Oct 16, 2023
@thomreis thomreis deleted the ecal-online-dqm-ratio-timing-default-132x-part2 branch February 2, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants