-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the ratio timing method for ECAL online DQM - 132X #42933
Use the ratio timing method for ECAL online DQM - 132X #42933
Conversation
A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_13_2_X. It involves the following packages:
@antoniovagnerini, @nothingface0, @rvenditti, @cmsbuild, @tjavaid, @syuvivida can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
type ecal |
please test |
backport of #42932 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eff76c/35024/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The master PR has diverged a bit from this now. It has also not been merged yet. I will make an additional PR to 132X to add the difference and match the master PR. |
PR description:
This PR sets the ECAL timing algorithm used in the online DQM reconstruction to the ratio method. Like this the online DQM monitors the algorithm that is used at the HLT and can also directly use the calibrations and offsets from the HLT GT.
This PR should replace #42855 on the online DQM.
PR validation:
Ran ecal_dqm_sourceclient-live_cfg.py configuration locally.
Backport of #42932