Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the ratio timing method for ECAL online DQM - 132X #42933

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Oct 3, 2023

PR description:

This PR sets the ECAL timing algorithm used in the online DQM reconstruction to the ratio method. Like this the online DQM monitors the algorithm that is used at the HLT and can also directly use the calibrations and offsets from the HLT GT.

This PR should replace #42855 on the online DQM.

PR validation:

Ran ecal_dqm_sourceclient-live_cfg.py configuration locally.

Backport of #42932

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2023

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_13_2_X.

It involves the following packages:

  • DQM/Integration (dqm)

@antoniovagnerini, @nothingface0, @rvenditti, @cmsbuild, @tjavaid, @syuvivida can you please review it and eventually sign? Thanks.
@francescobrivio, @wang0jin, @threus, @rchatter, @thomreis, @argiro, @batinkov this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

thomreis commented Oct 3, 2023

type ecal

@cmsbuild cmsbuild added the ecal label Oct 3, 2023
@thomreis
Copy link
Contributor Author

thomreis commented Oct 3, 2023

please test

@tjavaid
Copy link

tjavaid commented Oct 3, 2023

backport of #42932

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eff76c/35024/summary.html
COMMIT: dd6a14b
CMSSW: CMSSW_13_2_X_2023-10-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42933/35024/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198423
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198401
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Oct 4, 2023

+1

  • P5 tests ok

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c5404da into cms-sw:CMSSW_13_2_X Oct 6, 2023
@thomreis
Copy link
Contributor Author

thomreis commented Oct 6, 2023

The master PR has diverged a bit from this now. It has also not been merged yet. I will make an additional PR to 132X to add the difference and match the master PR.
For online DQM I think there is no need to update.

@thomreis thomreis deleted the ecal-online-dqm-ratio-timing-default-132x branch February 2, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants